Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator enhancements and minor improvements #391

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

shubhobm
Copy link
Collaborator

Major

Added generator support for

  • Public endpoints in Octo
  • Private endpoints in Hugging Face
  • Private endpoints in Replicate

Minor

  • Updated README with generator information and table of probes
  • Deleted dependency fschat that doesn't seem to be used. More importantly there's a dependency conflict: fschat depends on pydantic version <2, while octoai-sdk version 0.8.0 that supports public endpoints depends on pydantic >=2.1.1.
  • Minor additions and bugfixes to some docstrings

@leondz leondz self-assigned this Dec 24, 2023
@leondz
Copy link
Collaborator

leondz commented Dec 24, 2023

Will review soon. Thanks for everything, including proposing a fix for the pydantic version conflict!

@leondz leondz merged commit 273cb33 into NVIDIA:main Jan 9, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants