Skip to content

docs(notice): add Boulder MPL attribution - #23

Merged
jingxiang-z merged 1 commit into
mainfrom
chore/boulder-mpl-notice
Jul 29, 2026
Merged

docs(notice): add Boulder MPL attribution#23
jingxiang-z merged 1 commit into
mainfrom
chore/boulder-mpl-notice

Conversation

@jingxiang-z

@jingxiang-z jingxiang-z commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • My commits are signed off (git commit -s) per the DCO in the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Updated third-party dependency and licensing notices.
    • Added Mozilla Public License 2.0 information and attribution for included components.
    • Expanded source-availability statements for distributed binaries.

Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The NOTICE file now covers third-party components shipped in distributed binaries and adds MPL 2.0 attribution and source-availability information for github.com/letsencrypt/boulder.

Changes

Licensing notice

Layer / File(s) Summary
NOTICE scope and attribution updates
NOTICE
The introductory scope includes distributed binary components, and the licensing section adds MPL 2.0 language plus pinned github.com/letsencrypt/boulder attribution and source details.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding Boulder MPL attribution in the NOTICE file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/boulder-mpl-notice

Comment @coderabbitai help to get the list of available commands.

@jingxiang-z jingxiang-z self-assigned this Jul 29, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
NOTICE (1)

61-62: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Use the full commit SHA for the “Exact source” URL.

The referenced Boulder commit is de9c06129bec92b93cd66cc0be4a33ff2b71f996; using the complete SHA makes the source mapping unambiguous and better supports the MPL executable-source availability requirement. (github.com)

Proposed fix
-https://github.com/letsencrypt/boulder/tree/de9c06129bec
+https://github.com/letsencrypt/boulder/tree/de9c06129bec92b93cd66cc0be4a33ff2b71f996
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@NOTICE` around lines 61 - 62, Update the “Exact source” URL in NOTICE to use
the full Boulder commit SHA de9c06129bec92b93cd66cc0be4a33ff2b71f996 instead of
the abbreviated SHA, preserving the existing repository reference.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@NOTICE`:
- Around line 61-62: Update the “Exact source” URL in NOTICE to use the full
Boulder commit SHA de9c06129bec92b93cd66cc0be4a33ff2b71f996 instead of the
abbreviated SHA, preserving the existing repository reference.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 40fa3a0a-2d35-4ab5-b455-e63017c1a669

📥 Commits

Reviewing files that changed from the base of the PR and between 37cd4f4 and f59ca7c.

📒 Files selected for processing (1)
  • NOTICE

@jingxiang-z
jingxiang-z merged commit 54f9c00 into main Jul 29, 2026
3 checks passed
@jingxiang-z
jingxiang-z deleted the chore/boulder-mpl-notice branch July 29, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants