docs(notice): add Boulder MPL attribution - #23
Conversation
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
📝 WalkthroughWalkthroughThe ChangesLicensing notice
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
NOTICE (1)
61-62: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winUse the full commit SHA for the “Exact source” URL.
The referenced Boulder commit is
de9c06129bec92b93cd66cc0be4a33ff2b71f996; using the complete SHA makes the source mapping unambiguous and better supports the MPL executable-source availability requirement. (github.com)Proposed fix
-https://github.com/letsencrypt/boulder/tree/de9c06129bec +https://github.com/letsencrypt/boulder/tree/de9c06129bec92b93cd66cc0be4a33ff2b71f996🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@NOTICE` around lines 61 - 62, Update the “Exact source” URL in NOTICE to use the full Boulder commit SHA de9c06129bec92b93cd66cc0be4a33ff2b71f996 instead of the abbreviated SHA, preserving the existing repository reference.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@NOTICE`:
- Around line 61-62: Update the “Exact source” URL in NOTICE to use the full
Boulder commit SHA de9c06129bec92b93cd66cc0be4a33ff2b71f996 instead of the
abbreviated SHA, preserving the existing repository reference.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 40fa3a0a-2d35-4ab5-b455-e63017c1a669
📒 Files selected for processing (1)
NOTICE
Description
Checklist
git commit -s) per the DCO in the Contributing Guidelines.Summary by CodeRabbit