Add modular FlashDreams application runner - #453
Conversation
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
| @@ -0,0 +1,26 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
I feel like flashdreams_app shouldn't be called app, it is the runner that can run other apps. and it shouldn't be located in a place parallel to t2v_app. The runner is the "host", "t2v" is the thing that gets run by the host.
There was a problem hiding this comment.
yea, once the basic logic is implemented, this is easy to change.
| spec=spec, | ||
| device=environment.device, | ||
| ) | ||
| if args.mode == "webrtc": |
There was a problem hiding this comment.
so the main loop is sort of duplicated and implemented differently in the webrtc path and mp4 path. This is fine for now but could be cleaned up by abstracting native window/web rtc into objects, so you make the main loop implemented just once.
There was a problem hiding this comment.
with the current runtime API, looks like we have to separate it into branches
|
|
||
| @dataclass(frozen=True, kw_only=True, slots=True) | ||
| class PipelineAppSpec: | ||
| """Declarative application definition consumed by the generic host runtime.""" |
There was a problem hiding this comment.
I don't think you can possibly express all forms of applications in a declarative way. An application should be defined by an object that provides init() and generate(), not a metadata/manifest.
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Use the shared inference session spelling directly to remove the duplicate generate adapter and keep runner and WebRTC execution aligned. Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Architecture