Preserve setup-time driver invariants - #439
Merged
jarcherNV merged 5 commits intoAug 11, 2026
Merged
Conversation
Keep setup-time DriverInvariantError exceptions out of normal setup error policy handling in both batch and realtime demo drivers. Add regression coverage for setup invariant propagation and document MP4 generation handling across realtime resets.
Contributor
Greptile SummaryThe PR moves Lingbot demo input preparation from the legacy mapping layer into a model-owned provider while preserving legacy behavior in tests. It also ensures setup-time driver invariant errors propagate directly, narrows compatibility-runner support to mapped scenarios, relaxes Lingbot session startup to support provider-prepared inputs, and documents continuous MP4 recording across realtime resets. Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Driver
participant Adapter
participant Provider as LingbotInputProvider
participant Session
participant Sink
Adapter->>Provider: create from PreparedScenario metadata
Driver->>Provider: prepare_initial_input()
Driver->>Session: start/reset(initial input)
loop each input window
Driver->>Provider: prepare_step(requirements, window)
Provider-->>Driver: camera tensors and prompt update
Driver->>Session: step(prepared input)
Session-->>Driver: StepResult
Driver->>Sink: write(result)
end
Driver->>Provider: reset() on generation reset
Reviews (5): Last reviewed commit: "Update LingBot input mapping test for sh..." | Re-trigger Greptile |
Make the migrated LingBot demo provider convert UserInputWindow values directly into model InferenceInput, including trace slicing, live camera integration, skipped WebRTC input catch-up, and text-event prompt updates. Allow shared replay runs to use mapping-free model providers while keeping legacy compatibility runners mapping-gated, and update LingBot parity coverage against the old mapping path.
Update the LingBot WebRTC inference-session startup path so shared demo sessions only require an initialized rollout, not the legacy input mapping. Clarify the remaining direct-session compatibility path and add assertions that the migrated LingBot WebRTC demo uses a mapping-free shared scenario.
Adjust the event-driven LingBot scenario test to assert the migrated mapping-free shared provider behavior. The test now drives the scenario through LingbotInputProvider instead of expecting PreparedScenario.mapping to contain a legacy LingbotInputMapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep setup-time DriverInvariantError exceptions out of normal setup error policy handling in both batch and realtime demo drivers. Add regression coverage for setup invariant propagation and document MP4 generation handling across realtime resets.