Restore shared WebRTC manager input helpers - #432
Merged
jarcherNV merged 2 commits intoAug 8, 2026
Conversation
Contributor
Greptile SummaryThe PR restores shared WebRTC input canonicalization and inference-session helpers, migrates Lingbot to the shared session path, and fixes completed inference sessions so they close normally rather than entering the retry policy.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant Manager as WebRTC Manager
participant Canonicalizer
participant Session as Inference Session
Client->>Manager: key/text event
Manager->>Manager: validate and buffer event
Manager->>Canonicalizer: canonicalize events for TimeWindow
Canonicalizer-->>Manager: canonical inputs
Manager->>Session: next_step_request()
alt request available
Manager->>Session: step(mapped inputs)
Session-->>Manager: StepResult
Manager-->>Client: video chunk and chunk_done
else session exhausted
Session-->>Manager: None
Manager->>Manager: close active session
end
Reviews (2): Last reviewed commit: "fix(webrtc): restore session completion ..." | Re-trigger Greptile |
Treat completed inference sessions as terminal in the shared WebRTC manager, restore LingBot's session-branch adapter against the current model-session core, and update affected WebRTC tests for the current result and manager APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.