Skip to content

Unify serving paths - #429

Merged
gtong-nv merged 22 commits into
dev/jarcher/inference-runtime-apifrom
dev/gtong/output-stream
Aug 8, 2026
Merged

Unify serving paths#429
gtong-nv merged 22 commits into
dev/jarcher/inference-runtime-apifrom
dev/gtong/output-stream

Conversation

@gtong-nv

@gtong-nv gtong-nv commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR consolidates replay, WebRTC, and local-window serving around common runtime, result, output, and lifecycle abstractions.

  • Introduces a canonical layout-aware StepResult and separates video collection from post-processing.
  • Adds a thread-affine runtime worker and migrates integration lifecycle operations onto it.
  • Unifies WebRTC management, encoding, application construction, and capability-driven output routing.
  • Reuses shared Lingbot and OmniDreams model-session cores across their supported output modes.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.

No blocking failure remains.

Important Files Changed

Filename Overview
flashdreams/flashdreams/infra/results.py Defines the canonical immutable, layout-aware inference result consumed across output paths.
flashdreams/flashdreams/infra/video_output.py Refactors post-processing to emit StepResult objects and moves collection into a dedicated collector.
flashdreams/flashdreams/runtime/worker.py Adds serialized thread-affine runtime execution with ordered draining during shutdown.
flashdreams/flashdreams/serving/webrtc/manager.py Migrates WebRTC session orchestration to the canonical request/result runtime boundary.
flashdreams/flashdreams/serving/output_targets.py Replaces model-name routing with integration-provided output adapter capabilities.
integrations/lingbot/lingbot/model_session.py Centralizes Lingbot generation and output-stream state for reuse across serving modes.
integrations/omnidreams/omnidreams/model_session.py Centralizes OmniDreams model lifecycle and output processing across replay, WebRTC, and local presentation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Inputs["Replay / WebRTC / Local inputs"] --> Runtime["Thread-affine runtime worker"]
  Runtime --> Session["Integration model session"]
  Session --> Stream["VideoOutputStream"]
  Stream --> Result["StepResult"]
  Result --> MP4["MP4 output target"]
  Result --> WebRTC["WebRTC encoder"]
  Result --> Local["Local presentation"]
Loading

Reviews (3): Last reviewed commit: "Share demo application lifecycle" | Re-trigger Greptile

@gtong-nv
gtong-nv force-pushed the dev/gtong/output-stream branch from 35a0bd5 to 273bb39 Compare August 8, 2026 01:18
@gtong-nv
gtong-nv merged commit 4ce8a42 into dev/jarcher/inference-runtime-api Aug 8, 2026
3 checks passed
@gtong-nv
gtong-nv deleted the dev/gtong/output-stream branch August 8, 2026 04:19
jarcherNV pushed a commit that referenced this pull request Aug 8, 2026
* Canonicalize generated video step results

* Simplify video output stream consumption

* Pass step results through WebRTC delivery

* Run serving runtimes on thread-affine workers

* Unify Lingbot model session execution

* Unify OmniDreams model session execution

* Make WebRTC manager capabilities explicit

* Define explicit WebRTC app adapter contracts

* Route outputs through integration capabilities

* Drive WebRTC generation with step requests

* Fix serving type-check regressions

* Apply repository-wide lint fixes

* Skip unavailable Transformer Engine in CPU tests

* Record serving architecture validation

* Unify WebRTC session manager implementations

* Consolidate WebRTC runtime lifecycle

* refactor(omnidreams): use shared WebRTC demo APIs

* refactor(omnidreams): remove legacy WebRTC implementation

* refactor(omnidreams): remove WebRTC postprocessing

* Consolidate WebRTC demo integrations

* Simplify WebRTC demo launch path

* Share demo application lifecycle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant