Use raft::util::popc(...) public API#249
Merged
Merged
Conversation
divyegala
added
bug
divyegala
changed the title
raft::core::popc(...) public APIraft::popc(...) public API
divyegala
changed the title
raft::popc(...) public APIraft::util::popc(...) public API
rhdong
reviewed
Jul 25, 2024
rhdong
reviewed
Jul 25, 2024
This was referenced Jul 25, 2024
cjnolet
approved these changes
Jul 25, 2024
Contributor
Author
|
/merge |
divyegala
added a commit
to divyegala/cuvs
that referenced
this pull request
Jul 31, 2024
NVIDIA/raft#2346 introduced a breaking change in the API. This PR fixes the API usage. Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#249
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVIDIA/raft#2346 introduced a breaking change in the API. This PR fixes the API usage.