Python API for CAGRA+HNSW#246
Conversation
divyegala
added
feature request
|
@divyegala I observed that same pip devcontainer build failure on an unrelated PR: #247 (comment) So I suspect it's unrelated to your changes here. |
|
@jameslamb I suspect it's related to this PR NVIDIA/raft#2346 What I cannot figure out is why conda-cpp builds pass (new conda packages released?) but wheel builds fail. cuVS wheel builds pick up libraft wheel builds? |
|
Maybe conda packages weren't out yet when the builds failed? Wheel builds will pull the source of raft to rebuild the static lib (unless you changed something in how cuvs wheels specifically are built, but I don't see any indication of that in the CMake). |
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
Looks good overall. Mostly a couple small documentation-related things to polish this off and then I think it's ready to merge.
| bool include_dataset); | ||
|
|
||
| /** | ||
| * Save the CAGRA index to file in hnswlib format. |
There was a problem hiding this comment.
Should we add a note here that this must be loaded by the (patched) hnswlib wrappers inside cuVS and it can't just be loaded with hnswlib?
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
The implementation is shaping up great. Mostly minor things, but important nonetheless.
|
/merge |
4 participants
No description provided.