Skip to content

[BUG] Fixed uninitialized FJ constraint weights when the problem grows #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Aug 11, 2026
Merged

[BUG] Fixed uninitialized FJ constraint weights when the problem grows #1698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a4c4a6
fixed uninitialized FJ constraint weights when the problem grows
nguidotti Aug 11, 2026
2875221
Merge branch 'main' into fix-fj-infinite-constraints
nguidotti Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions cpp/src/mip_heuristics/feasibility_jump/feasibility_jump.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,9 +1036,20 @@ void fj_t<i_t, f_t>::resize_vectors(const raft::handle_t* handle_ptr)
climbers[0]->grid_delta_buf.resize(update_weights_launch_dims.first.x, handle_ptr->get_stream());

// FJ related vars
cstr_weights.resize(pb_ptr->n_constraints, handle_ptr->get_stream());
cstr_right_weights.resize(pb_ptr->n_constraints, handle_ptr->get_stream());
cstr_left_weights.resize(pb_ptr->n_constraints, handle_ptr->get_stream());
// the problem can gain constraints between two runs (e.g. the objective cutting plane added by
// the feasibility pump), and resize leaves the new elements uninitialized: give them the default
// weight
auto resize_weights = [&](rmm::device_uvector<f_t>& weights) {
const auto old_size = weights.size();
weights.resize(pb_ptr->n_constraints, handle_ptr->get_stream());
if (old_size < weights.size()) {
thrust::uninitialized_fill(
handle_ptr->get_thrust_policy(), weights.begin() + old_size, weights.end(), 1.);
}
};
resize_weights(cstr_weights);
resize_weights(cstr_right_weights);
resize_weights(cstr_left_weights);
constraint_lower_bounds_csr.resize(pb_ptr->coefficients.size(), handle_ptr->get_stream());
constraint_upper_bounds_csr.resize(pb_ptr->coefficients.size(), handle_ptr->get_stream());
cstr_coeff_reciprocal.resize(pb_ptr->coefficients.size(), handle_ptr->get_stream());
Expand Down