Skip to content

Upgrade cmake version to include the PDLP objective offset fix - #1695

Merged
rapids-bot[bot] merged 2 commits into
mainfrom
new_pslp_version
Aug 11, 2026
Merged

Upgrade cmake version to include the PDLP objective offset fix#1695
rapids-bot[bot] merged 2 commits into
mainfrom
new_pslp_version

Conversation

@Kh4ster

@Kh4ster Kh4ster commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Upgrade cmake version to include the PSLP objective offset fix

@Kh4ster Kh4ster self-assigned this Aug 10, 2026
@Kh4ster
Kh4ster requested review from a team as code owners August 10, 2026 15:15
@Kh4ster Kh4ster added feature request New feature or request non-breaking Introduces a non-breaking change labels Aug 10, 2026
@Kh4ster
Kh4ster requested review from tmckayus and removed request for tmckayus August 10, 2026 15:15
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a70cc561-236f-4c3f-b697-af935b4aea72

📥 Commits

Reviewing files that changed from the base of the PR and between f3ebc67 and 82604d0.

📒 Files selected for processing (1)
  • cpp/CMakeLists.txt

📝 Walkthrough

Walkthrough

The CMake configuration updates the pinned PSLP dependency from v0.0.8 to v0.0.10.

Changes

PSLP dependency update

Layer / File(s) Summary
Update PSLP pin
cpp/CMakeLists.txt
The PSLP FetchContent declaration now uses Git tag v0.0.10 instead of v0.0.8.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: akifcorduk, aliceb-nv, tmckayus

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title describes the dependency upgrade and objective offset fix, although it names PDLP instead of the updated PSLP dependency.
Description check ✅ Passed The description relates to the changeset by identifying the PSLP upgrade for the objective offset fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new_pslp_version

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

CI Test Summary

✅ All 31 test job(s) passed.

@Kh4ster

Kh4ster commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit f0ecadc into main Aug 11, 2026
98 checks passed
@Kh4ster
Kh4ster deleted the new_pslp_version branch August 11, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants