Repository navigation
Add support for sparsity exploitation for SOCs of large dimensionality #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
01f3469
Add support for sparsity exploitation for SOCP of large dimensionality
yuwenchen95 9c8965e
Merge branch 'main' into sparse-socp
yuwenchen95 4ed64ef
Stricter IR tolerance for SOCP with sparse socs
yuwenchen95 9622be8
explicit matrix-vector product in IR
yuwenchen95 e5b81d7
Remove a slow inner loop in CSR matrix buildup
yuwenchen95 dc2e7f0
clean up cusparse_view & add more ranges for profiling
yuwenchen95 1ffb4a7
Merge branch 'main' into sparse-socp
yuwenchen95 0a37e5d
Update of parameters
yuwenchen95 fd86c56
optimize operations in compute_target_mu; clean up code
yuwenchen95 14d510c
Fuse the sparse SOC augmented-system assembly and unify the bucket in…
yuwenchen95 2e3ba6b
Merge branch 'main' into sparse-socp
yuwenchen95 0d08c0a
test fix
yuwenchen95 47b612a
Optimize SOC cone step-length computation
yuwenchen95 2b18b6d
Addressing notation and comment issues
yuwenchen95 088bd7f
Remove redundant log
yuwenchen95 200ff63
Merge branch 'main' into sparse-socp
yuwenchen95 a4c1ed1
Remove barrier_csr_ir_matvec CSR IR matvec path
yuwenchen95 d02f67d
Move CSR KKT buildup to GPU
yuwenchen95 e24332e
Remove nvtx ranges
yuwenchen95 f3c8e7e
Regroup vectors and views of cones
yuwenchen95 a8754c1
Merge branch 'main' into sparse-socp
yuwenchen95 00116e9
minor code cleanup
yuwenchen95 51adc1b
parameter tuning for scalings
yuwenchen95 4c00d1e
Fix the bug for initial point computation
yuwenchen95 4f84f67
Merge branch 'main' into sparse-socp
yuwenchen95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,6 @@ | |
|
|
||
| #include <algorithm> | ||
| #include <cmath> | ||
| #include <cstdio> | ||
| #include <limits> | ||
| #include <vector> | ||
|
|
||
|
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
initis accumulatedblock_dimtimes instead of once.Every thread seeds
sum = init, andblock_reduce_t::Sumthen sums across allblock_dimthreads, so the result becomesΣ entries + block_dim * init(256×) rather thanΣ entries + init. The convenience overload at Line 157 currently passesf_t{0}, so this is latent today, but the publicoperator()at Line 114 accepts an arbitraryinit, so any non-zero caller would get a wrong cone sum. (The warp kernel has the same shape but only multiplies by 32, so the two paths are also inconsistent.)Apply
initonce, after the block reduction.🐛 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents