Skip to content

skills/cuopt-numerical-optimization-api-python: update with benchmark details - #1332

Merged
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-numerical-optimization-api-python
May 29, 2026
Merged

skills/cuopt-numerical-optimization-api-python: update with benchmark details#1332
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-numerical-optimization-api-python

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

update with benchmark details

@copy-pr-bot

copy-pr-bot Bot commented May 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

… details

Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv
ramakrishnap-nv force-pushed the skills-cuopt-numerical-optimization-api-python branch from 98dcd66 to 52c285c Compare May 29, 2026 01:17
@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review May 29, 2026 01:17
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner May 29, 2026 01:17
@ramakrishnap-nv
ramakrishnap-nv requested a review from tmckayus May 29, 2026 01:17
@ramakrishnap-nv ramakrishnap-nv self-assigned this May 29, 2026
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 29, 2026
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a new NVSkills evaluation report (BENCHMARK.md), updates the skill-card metadata and evaluation results, inserts a single blank line in SKILL.md front-matter, and replaces the Sigstore signature bundle file for the cuopt-numerical-optimization-api-python skill.

Changes

Skill docs and signing updates

Layer / File(s) Summary
Front-matter whitespace adjustment
skills/cuopt-numerical-optimization-api-python/SKILL.md
A blank line is inserted in the document front-matter at line 16.
Add BENCHMARK and update skill-card
skills/cuopt-numerical-optimization-api-python/BENCHMARK.md, skills/cuopt-numerical-optimization-api-python/skill-card.md
Adds an NVSkills-Eval BENCHMARK report and revises the skill-card content (owner/license display, references, skill output metadata, and populated evaluation/results with a FAIL verdict and per-dimension scores).
Regenerate Sigstore signature bundle
skills/cuopt-numerical-optimization-api-python/skill.oms.sig
Replaces the Sigstore DSSE bundle payload and signature bytes (updated predicate/resource digests and serialization.ignore_paths entries).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • NVIDIA/cuopt#1308: Related updates to skill attestation and evaluation artifacts for cuopt-numerical-optimization-api-python.
  • NVIDIA/cuopt#1287: Updates NVSkills validation artifacts, BENCHMARK and signature regeneration for the same skill.
  • NVIDIA/cuopt#1301: Another PR affecting skill documentation and regenerating the skill.oms.sig bundle.

Suggested reviewers

  • tmckayus
  • Iroy30
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes, which include adding a BENCHMARK.md file and updating skill-related documentation with benchmark evaluation details.
Description check ✅ Passed The description is directly related to the changeset, as it references updating with benchmark details, which aligns with the primary additions of BENCHMARK.md and benchmark-related updates to skill cards.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skills-cuopt-numerical-optimization-api-python

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/cuopt-numerical-optimization-api-python/SKILL.md`:
- Line 16: This PR modifies
skills/cuopt-numerical-optimization-api-python/SKILL.md and must run pre-commit
across skills/ before merge: run `pre-commit run --all-files
--show-diff-on-failure`, apply and commit any fixes (ensuring updated files in
the same branch), then add a comment with `/nvskills-ci` on the PR so the
nv-nvskill-ci[bot] signature commit is produced and remains; confirm the final
commit(s) include the pre-commit changes and the bot signature.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 003350af-7546-4277-8d43-6e85396c04ad

📥 Commits

Reviewing files that changed from the base of the PR and between 6c61fcb and 52c285c.

📒 Files selected for processing (1)
  • skills/cuopt-numerical-optimization-api-python/SKILL.md

- python
---


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

❓ Verification inconclusive

🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE="skills/cuopt-numerical-optimization-api-python/SKILL.md"

echo "== File exists and line 1-40 =="
ls -l "$FILE"
nl -ba "$FILE" | sed -n '1,60p'

echo "== Diff for the file (if any) =="
if git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
  git --no-pager diff -- "$FILE" || true
  echo
  echo "== Current HEAD commit message =="
  git --no-pager log -1 --format='%H%n%B' || true
else
  echo "Not a git repo in this sandbox."
fi

echo "== pre-commit config presence =="
ls -la .pre-commit-config.yaml pre-commit-config.yaml .pre-commit-config.yml pre-commit-config.yml 2>/dev/null || true

echo "== Search for documentation about /nvskills-ci =="
rg -n "/nvskills-ci" -S . || true

echo "== Search for guidance mentioning pre-commit run --all-files =="
rg -n "pre-commit run --all-files" -S . || true

echo "== pre-commit docs or CONTRIBUTING references =="
for f in README.md CONTRIBUTING.md .github/CONTRIBUTING.md .github/workflows/* 2>/dev/null; do
  if [ -f "$f" ]; then
    echo "---- $f ----"
    rg -n "pre-commit|nvskills|/nvskills-ci" -S "$f" || true
  fi
done

Repository: NVIDIA/cuopt

Length of output: 255


🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE="skills/cuopt-numerical-optimization-api-python/SKILL.md"

echo "== File exists and show first 80 lines =="
ls -l "$FILE"
awk 'NR<=80 {printf "%6d\t%s\n", NR, $0}' "$FILE"

echo "== Check if this is a git repo (for HEAD commit message) =="
if command -v git >/dev/null 2>&1 && git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
  echo "Git repo: yes"
  echo "== HEAD commit message (subject+body) =="
  git --no-pager log -1 --format='%s%n%n%b' || true
else
  echo "Git repo: no (or git not available)"
fi

echo "== pre-commit config presence =="
ls -la .pre-commit-config.yaml pre-commit-config.yaml .pre-commit-config.yml pre-commit-config.yml 2>/dev/null || true

echo "== Search for /nvskills-ci guidance =="
rg -n "/nvskills-ci" -S . || true

echo "== Search for guidance mentioning pre-commit run --all-files =="
rg -n "pre-commit run --all-files" -S . || true

echo "== Search for any CONTRIBUTING/README references =="
for f in README.md CONTRIBUTING.md .github/CONTRIBUTING.md .github/workflows/*; do
  if [ -f "$f" ]; then
    echo "---- $f ----"
    rg -n "pre-commit|nvskills|/nvskills-ci" -S "$f" || true
  fi
done

Repository: NVIDIA/cuopt

Length of output: 13305


Trigger NVSkills CI and show pre-commit evidence for this skills/ update
skills/cuopt-numerical-optimization-api-python/SKILL.md is under skills/ and requires: running pre-commit run --all-files --show-diff-on-failure (and committing any resulting fixes) and having /nvskills-ci commented on the PR so the nv-nvskill-ci[bot] signature commit is added and remains. The current commit already includes a Signed-off-by; please add/confirm the pre-commit and /nvskills-ci items in the PR.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/cuopt-numerical-optimization-api-python/SKILL.md` at line 16, This PR
modifies skills/cuopt-numerical-optimization-api-python/SKILL.md and must run
pre-commit across skills/ before merge: run `pre-commit run --all-files
--show-diff-on-failure`, apply and commit any fixes (ensuring updated files in
the same branch), then add a comment with `/nvskills-ci` on the PR so the
nv-nvskill-ci[bot] signature commit is produced and remains; confirm the final
commit(s) include the pre-commit changes and the bot signature.

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/cuopt-numerical-optimization-api-python/skill-card.md`:
- Around line 62-64: Add a single blank line between the preceding heading and
the evaluation table that begins with the row starting "| Dimension | Num |
`claude-code` | `codex` |" in skill-card.md so the table is not immediately
adjacent to the heading (this satisfies markdownlint MD058); edit the content
around the heading/table and insert one empty line before that table to fix the
lint error and then run pre-commit (pre-commit run --all-files
--show-diff-on-failure) to verify formatting.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 12fa51d8-d0e7-4de7-8a34-25de31e884fc

📥 Commits

Reviewing files that changed from the base of the PR and between 52c285c and 739c9fd.

📒 Files selected for processing (3)
  • skills/cuopt-numerical-optimization-api-python/BENCHMARK.md
  • skills/cuopt-numerical-optimization-api-python/skill-card.md
  • skills/cuopt-numerical-optimization-api-python/skill.oms.sig

Comment on lines +62 to +64
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a blank line before the evaluation table to satisfy markdownlint MD058.

The table starts immediately after the heading and triggers the reported lint warning.

Proposed fix
 ## Evaluation Results: <br>
+
 | Dimension | Num | `claude-code` | `codex` |
 |---|---:|---:|---:|
 | Security | 2 | 100% (+0%) | 100% (+0%) |

As per coding guidelines Use pre-commit run --all-files --show-diff-on-failure to check code formatting and linting on all files before committing.

🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 62-62: Tables should be surrounded by blank lines

(MD058, blanks-around-tables)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/cuopt-numerical-optimization-api-python/skill-card.md` around lines 62
- 64, Add a single blank line between the preceding heading and the evaluation
table that begins with the row starting "| Dimension | Num | `claude-code` |
`codex` |" in skill-card.md so the table is not immediately adjacent to the
heading (this satisfies markdownlint MD058); edit the content around the
heading/table and insert one empty line before that table to fix the lint error
and then run pre-commit (pre-commit run --all-files --show-diff-on-failure) to
verify formatting.

@ramakrishnap-nv
ramakrishnap-nv merged commit f9c42f2 into main May 29, 2026
4 checks passed
@ramakrishnap-nv
ramakrishnap-nv deleted the skills-cuopt-numerical-optimization-api-python branch July 9, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants