skills/cuopt-numerical-optimization-api-cli: update with benchmark details - #1331
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…tails Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
12b9baa to
816f6ea
Compare
📝 WalkthroughWalkthroughAdds an NVSkills evaluation report, updates the skill card metadata and SKILL.md spacing, and replaces the skill’s sigstore DSSE bundle to reflect updated payload digests and signatures. ChangesSkill packaging and docs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-numerical-optimization-api-cli/skill-card.md`:
- Around line 61-63: The markdown heading "## Evaluation Results:" is followed
immediately by a table, triggering MD058; insert a single blank line between the
"## Evaluation Results:" heading and the start of the table (the line beginning
with "| Dimension |") in skill-card.md so there is one empty line separating
them, then run pre-commit checks (pre-commit run --all-files
--show-diff-on-failure) to verify the lint warning is resolved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1187e410-15e4-4ea8-a5e1-2ad128d1bdcc
📒 Files selected for processing (3)
skills/cuopt-numerical-optimization-api-cli/BENCHMARK.mdskills/cuopt-numerical-optimization-api-cli/skill-card.mdskills/cuopt-numerical-optimization-api-cli/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
- skills/cuopt-numerical-optimization-api-cli/BENCHMARK.md
| ## Evaluation Results: <br> | ||
| | Dimension | Num | `claude-code` | `codex` | | ||
| |---|---:|---:|---:| |
There was a problem hiding this comment.
Add a blank line before the evaluation results table.
The table starts immediately after the heading, which triggers MD058 (blanks-around-tables). Please insert one blank line between the heading and the table.
🛠️ Suggested fix
## Evaluation Results: <br>
+
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|As per coding guidelines, "Use pre-commit run --all-files --show-diff-on-failure to check code formatting and linting on all files before committing".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Evaluation Results: <br> | |
| | Dimension | Num | `claude-code` | `codex` | | |
| |---|---:|---:|---:| | |
| ## Evaluation Results: <br> | |
| | Dimension | Num | `claude-code` | `codex` | | |
| |---|---:|---:|---:| |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 62-62: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-numerical-optimization-api-cli/skill-card.md` around lines 61 -
63, The markdown heading "## Evaluation Results:" is followed immediately by a
table, triggering MD058; insert a single blank line between the "## Evaluation
Results:" heading and the start of the table (the line beginning with "|
Dimension |") in skill-card.md so there is one empty line separating them, then
run pre-commit checks (pre-commit run --all-files --show-diff-on-failure) to
verify the lint warning is resolved.
update with benchmark details