Rename skill-evolution to cuopt-skill-evolution - #1330
Conversation
|
/nvskills-ci |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR renames and rehomes the skill-evolution system to ChangesSkill Evolution System Reorganization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/cuopt-skill-evolution/SKILL.md (1)
214-219:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required NVSkills CI trigger step for
skills/PRs.This validation section omits the repository-required step to request NVSkills CI (
/nvskills-ci) and preserve the signature commit forskills/changes before merge. Please add it explicitly here (or in an equivalent mandatory checklist location) so the workflow is enforceable.As per coding guidelines: “For PRs changing content under
skills/directory, request NVSkills CI validation by commenting/nvskills-ciand ensure the signature commit remains in the PR”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/cuopt-skill-evolution/SKILL.md` around lines 214 - 219, Update the Validation section in SKILL.md to include the required NVSkills CI trigger and signature commit step: explicitly state that for PRs changing content under skills/ reviewers must comment `/nvskills-ci` to request NVSkills CI validation and must preserve the signature commit in the PR before merge (in addition to the existing checks `./ci/utils/validate_skills.sh` and `./ci/test_skills_assets.sh`); add a single checklist bullet under "Validation" mentioning `/nvskills-ci` and "preserve signature commit" so the workflow is enforceable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@skills/cuopt-skill-evolution/SKILL.md`:
- Around line 214-219: Update the Validation section in SKILL.md to include the
required NVSkills CI trigger and signature commit step: explicitly state that
for PRs changing content under skills/ reviewers must comment `/nvskills-ci` to
request NVSkills CI validation and must preserve the signature commit in the PR
before merge (in addition to the existing checks `./ci/utils/validate_skills.sh`
and `./ci/test_skills_assets.sh`); add a single checklist bullet under
"Validation" mentioning `/nvskills-ci` and "preserve signature commit" so the
workflow is enforceable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ecaf2981-7153-489e-852e-4f19c4760215
📒 Files selected for processing (10)
.agents/rules/cuopt-skill-evolution.mdc.agents/rules/skill-evolution.mdc.claude-plugin/marketplace.jsonAGENTS.mdskills/cuopt-skill-evolution/SKILL.mdskills/cuopt-skill-evolution/evals/evals.jsonskills/cuopt-skill-evolution/skill-card.mdskills/cuopt-skill-evolution/skill.oms.sigskills/cuopt-user-rules/SKILL.mdskills/skill-evolution/evals/evals.json
💤 Files with no reviewable changes (2)
- .agents/rules/skill-evolution.mdc
- skills/skill-evolution/evals/evals.json
a475651 to
b4eba8d
Compare
|
/nvskill-ci |
Prefix the skill-evolution workflow skill with cuopt- to match the product-scoped naming convention used by the other cuOpt skills in the catalog. Updates the directory name, the .agents/rules/.mdc filename, the marketplace.json entry (name + source), the AGENTS.md bullets and prose references, the in-file self-references in SKILL.md, the expected_skill field in the eval, and the post-correction-check reference in cuopt-user-rules/SKILL.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
b4eba8d to
b78b7fc
Compare
|
/nvskill-ci |
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Restore the eval that was deleted during the rename from skill-evolution to cuopt-skill-evolution (#1330). Updated expected_skill and references to the new name. --------- Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com> Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Co-authored-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Rename skill-evolution to cuopt-skill-evolution