Replace rapids-xgboost with xgboost in the CI. - #8440
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR replaces ChangesXGBoost dependency transition
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| - matrix: | ||
| packages: | ||
| - rapids-xgboost==26.10.*,>=0.0.0a0 | ||
| - conda-forge::xgboost>=3.3.0 |
There was a problem hiding this comment.
Must we specify conda-forge::? I'd like to remove that if it's not strictly necessary.
There was a problem hiding this comment.
The Rapids channel also has a package named xgboost: https://anaconda.org/channels/rapidsai/packages/xgboost/overview
There was a problem hiding this comment.
There was a problem hiding this comment.
We'll have to figure out what to do with the xgboost packages on rapidsai... strict channel priority is normally to our benefit but it may hurt us here (because we want to stop publishing a package on a higher priority channel). We can't delete the older xgboost packages from rapidsai without breaking the rapids package from past releases.
We may need to re-add the conda-forge:: here in the future, once we require a version newer than 3.3.0.
rapids-xgboost with xgboost in the CI.
|
/merge |
The CI will continue to install XGBoost from the rapidsai channel until the package is removed. See rapidsai/nvforest#185 (comment) Authors: - Jiaming Yuan (https://github.com/trivialfis) Approvers: - Philip Hyunsu Cho (https://github.com/chyunsu3) - Simon Adorf (https://github.com/csadorf) - Bradley Dice (https://github.com/bdice) URL: NVIDIA#8440
The CI will continue to install XGBoost from the rapidsai channel until the package is removed. See rapidsai/nvforest#185 (comment)