Remove deprecated legacy output types - #8439
Merged
Merged
Conversation
jcrist
added
improvement
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (17)
💤 Files with no reviewable changes (7)
🚧 Files skipped from review as they are similar to previous changes (9)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR removes deprecated output types, Numba array handling, related warnings, and the ChangesLegacy API removal
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4 tasks
Removes support for the following `output_type` values: - `"array"` - `"dataframe"` - `"series"` - `"df_obj"` - `"numba"`
jcrist
force-pushed
the
remove-legacy-output-types
branch
from
August 3, 2026 23:25
05a7356 to
5d2f8df
Compare
csadorf
approved these changes
Aug 4, 2026
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes support for the following deprecated
output_typevalues:"numba""dataframe""series""df_obj""array"The latter 4 are all aliases for other concrete types (e.g.
"array"is the same as"cupy"). For"numba",cumlnow treats numba inputs the same as any other non-cupy input type that implements__cuda_array_interface__(coerces tocupy, and returns cupy outputs by default). This code path is still tested in the generic estimator input/output types, but in most other places wherenumbawas explicitly part of the parametrized tests we've opted to simplify to remove that branch as duplicative ofcupyinputs.This also removes the deprecated
sparse_pairwise_distancesfunction. This should have been handled in #8435, but was accidentally missed. This is the only remaining deprecation in need of removal for 26.10 - I'm including it here to avoid another PR.Part of #8225.