skip Cython 3.2.7 - #8301
skip Cython 3.2.7#8301
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAll Cython version constraints are updated from ChangesCython 3.2.7 exclusion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks James! 🙏 Do we want to update these lines as well? |
I really don't think it's worth another CI run. That's documentation for users / developers, information about the floor and lack of ceiling is enough. |
|
Personally, no (though I selfishly just want this merged to get on with work). The issue seems to be some faulty upstream metadata being picked up (since 3.2.7 was marked as broken, it should be ignored in a working system). I'd leave it as is. |
|
Understandable Just trying to save future devs (or AI agents) running into this This could go in a follow up PR if we deem it worthwhile |
|
/merge |
Building against Cython 3.2.7 is failing, because of the issues described in cython/cython#7781
This ensures we skip that version here, which should unblock CI.
more details: #8287 (comment)