Skip to content

skip Cython 3.2.7 - #8301

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jameslamb:skip-cython-3.2.7
Jun 30, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jameslamb:skip-cython-3.2.7

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Building against Cython 3.2.7 is failing, because of the issues described in cython/cython#7781

This ensures we skip that version here, which should unblock CI.

more details: #8287 (comment)

@jameslamb
jameslamb requested a review from a team as a code owner June 30, 2026 18:33
@jameslamb
jameslamb requested a review from msarahan June 30, 2026 18:33
@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 30, 2026
@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue labels Jun 30, 2026
@jameslamb
jameslamb requested a review from jcrist June 30, 2026 18:37
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bb6ccc9b-05bc-445d-b375-755ad5e4247b

📥 Commits

Reviewing files that changed from the base of the PR and between 91f42d1 and 56618e6.

📒 Files selected for processing (7)
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • conda/environments/all_cuda-133_arch-aarch64.yaml
  • conda/environments/all_cuda-133_arch-x86_64.yaml
  • conda/recipes/cuml/recipe.yaml
  • dependencies.yaml
  • python/cuml/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated environment and build dependencies to avoid a known problematic Cython release.
    • Kept the minimum supported Cython version while excluding version 3.2.7 across supported build and test setups.

Walkthrough

All Cython version constraints are updated from >=3.2.2 to >=3.2.2,!=3.2.7 across dependencies.yaml, python/cuml/pyproject.toml, conda/recipes/cuml/recipe.yaml, and the four conda environment YAML files. A comment is added in dependencies.yaml and recipe.yaml documenting the reason for the exclusion.

Changes

Cython 3.2.7 exclusion

Layer / File(s) Summary
Cython pin in dependencies.yaml, pyproject.toml, and conda recipe
dependencies.yaml, python/cuml/pyproject.toml, conda/recipes/cuml/recipe.yaml
Adds !=3.2.7 to the Cython constraint and a comment referencing the known issue in dependencies.yaml and recipe.yaml. Both project.optional-dependencies.test and [tool.rapids-build-backend].requires entries in pyproject.toml are updated.
Generated conda environment YAMLs
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-129_arch-x86_64.yaml, conda/environments/all_cuda-133_arch-aarch64.yaml, conda/environments/all_cuda-133_arch-x86_64.yaml
Each environment YAML updates the cython entry to >=3.2.2,!=3.2.7.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/cuml#7836: Previously set the cython>=3.2.2 lower bound in the same files this PR modifies to add the !=3.2.7 exclusion.

Suggested labels

bug

Suggested reviewers

  • bdice
  • gforsyth
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: excluding Cython 3.2.7.
Description check ✅ Passed The description is directly related to the change and explains why Cython 3.2.7 is being skipped.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jameslamb

jameslamb commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Do we want to update these lines as well?

I really don't think it's worth another CI run. That's documentation for users / developers, information about the floor and lack of ceiling is enough.

@jcrist

jcrist commented Jun 30, 2026

Copy link
Copy Markdown
Member

Personally, no (though I selfishly just want this merged to get on with work).

The issue seems to be some faulty upstream metadata being picked up (since 3.2.7 was marked as broken, it should be ignored in a working system). I'd leave it as is.

@jakirkham

Copy link
Copy Markdown
Contributor

Understandable

Just trying to save future devs (or AI agents) running into this

This could go in a follow up PR if we deem it worthwhile

@jakirkham
jakirkham removed the request for review from msarahan June 30, 2026 19:29
@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 0579670 into NVIDIA:main Jun 30, 2026
105 checks passed
@jameslamb
jameslamb deleted the skip-cython-3.2.7 branch June 30, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants