Skip to content

refactor: switch to rapids-artifact-name for consistent artifact naming - #8174

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
gforsyth:rapids-artifact-name
Jun 9, 2026
Merged

refactor: switch to rapids-artifact-name for consistent artifact naming#8174
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
gforsyth:rapids-artifact-name

Conversation

@gforsyth

Copy link
Copy Markdown
Contributor

This PR swaps in rapids-artifact-name for rapids-package-name everywhere, and also removes any legacy named artifacts. All artifacts now follow the same naming convention (and that convention can be updated/expanded from a central location). Part of rapidsai/build-planning#270

@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 27, 2026
@copy-pr-bot

copy-pr-bot Bot commented May 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gforsyth

Copy link
Copy Markdown
Contributor Author

/ok to test

@gforsyth
gforsyth marked this pull request as ready for review May 27, 2026 19:10
@gforsyth
gforsyth requested a review from a team as a code owner May 27, 2026 19:10
@gforsyth
gforsyth requested a review from msarahan May 27, 2026 19:10
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e996999e-9186-4ff0-b869-d93bfeeedb35

📥 Commits

Reviewing files that changed from the base of the PR and between b88ea9e and 38edee5.

📒 Files selected for processing (3)
  • .github/workflows/pr.yaml
  • .github/workflows/test.yaml
  • ci/test_wheel_integrations.sh
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/pr.yaml
  • ci/test_wheel_integrations.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Standardized artifact naming and download patterns across CI build and test workflows.
    • Made artifact resolution CUDA-version aware to ensure correct conda packages and wheels are fetched.
    • Streamlined download/install steps for prebuilt packages and wheels used in CI.
    • Exported package name for downstream CI steps to improve artifact tracking.
    • Added explicit targeting for the libcuml package in CI artifact flows.
    • Set explicit publish keys for wheel publishing.
    • Updated copyright year to 2026.

Walkthrough

This PR standardizes CI artifact naming/downloads to use rapids-artifact-name (with --cuda "$RAPIDS_CUDA_VERSION") and rapids-download-from-github across build and test scripts and updates workflow invocations to pass package_name: libcuml.

Changes

Standardize CI artifact naming and download across conda and wheel build/test pipeline

Layer / File(s) Summary
Workflow configuration
.github/workflows/pr.yaml, .github/workflows/test.yaml
Adds package_name: libcuml input to the conda-cpp-checks reusable workflow invocation.
Build-stage artifact naming and exports
ci/build_cpp.sh, ci/build_docs.sh, ci/build_python.sh, ci/build_wheel_cuml.sh, ci/build_wheel_libcuml.sh
Build scripts now compute CUDA-scoped artifact identifiers with rapids-artifact-name and use rapids-download-from-github; several scripts export RAPIDS_PACKAGE_NAME. ci/build_cpp.sh copyright year updated.
Test-stage artifact download assignments
ci/test_cpp.sh, ci/test_python_common.sh, ci/test_notebooks.sh, ci/test_wheel.sh, ci/test_wheel_dask.sh, ci/test_wheel_integrations.sh
Test scripts set CPP_CHANNEL, PYTHON_CHANNEL, LIBCUML_WHEELHOUSE, and CUML_WHEELHOUSE by downloading artifacts selected via rapids-artifact-name scoped to RAPIDS_CUDA_VERSION, replacing prior helper-based lookup logic.
Publish job keys
.github/workflows/build.yaml
Adds/updates publish-wheel-search-key values for wheel publish jobs (cuml_wheel_cpp_libcuml, cuml_wheel_python_cuml).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • rapidsai/cuml#7758: Earlier refactor that moved CI scripts to use rapids-artifact-name for artifact identifiers; this PR continues that pattern across additional scripts and artifacts.

Suggested labels

conda

Suggested reviewers

  • msarahan
  • bdice
  • jcrist
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main refactoring effort: switching from rapids-package-name to rapids-artifact-name across multiple build and test scripts for consistent artifact naming.
Description check ✅ Passed The description clearly explains the change: replacing rapids-package-name with rapids-artifact-name and removing legacy artifacts to achieve consistent naming conventions managed centrally.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/build_wheel_cuml.sh`:
- Line 54: The RAPIDS_PACKAGE_NAME assignment uses rapids-artifact-name with an
empty --cuda flag; update the call that sets RAPIDS_PACKAGE_NAME (the line
invoking rapids-artifact-name) to pass the explicit CUDA version by adding
--cuda "$RAPIDS_CUDA_VERSION" (matching other scripts) so artifact names include
the concrete CUDA version; ensure the symbol RAPIDS_CUDA_VERSION is referenced
exactly and no other flags are changed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 87db1469-964b-4e9c-95cb-ee2bb010e1e2

📥 Commits

Reviewing files that changed from the base of the PR and between a8c262b and 389a1d0.

📒 Files selected for processing (12)
  • .github/workflows/pr.yaml
  • ci/build_cpp.sh
  • ci/build_docs.sh
  • ci/build_python.sh
  • ci/build_wheel_cuml.sh
  • ci/build_wheel_libcuml.sh
  • ci/test_cpp.sh
  • ci/test_notebooks.sh
  • ci/test_python_common.sh
  • ci/test_wheel.sh
  • ci/test_wheel_dask.sh
  • ci/test_wheel_integrations.sh

Comment thread ci/build_wheel_cuml.sh Outdated
@gforsyth
gforsyth force-pushed the rapids-artifact-name branch from 389a1d0 to e6889dc Compare May 27, 2026 19:18
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@gforsyth

gforsyth commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit cc7135b into NVIDIA:main Jun 9, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants