refactor: switch to rapids-artifact-name for consistent artifact naming - #8174
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR standardizes CI artifact naming/downloads to use ChangesStandardize CI artifact naming and download across conda and wheel build/test pipeline
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/build_wheel_cuml.sh`:
- Line 54: The RAPIDS_PACKAGE_NAME assignment uses rapids-artifact-name with an
empty --cuda flag; update the call that sets RAPIDS_PACKAGE_NAME (the line
invoking rapids-artifact-name) to pass the explicit CUDA version by adding
--cuda "$RAPIDS_CUDA_VERSION" (matching other scripts) so artifact names include
the concrete CUDA version; ensure the symbol RAPIDS_CUDA_VERSION is referenced
exactly and no other flags are changed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 87db1469-964b-4e9c-95cb-ee2bb010e1e2
📒 Files selected for processing (12)
.github/workflows/pr.yamlci/build_cpp.shci/build_docs.shci/build_python.shci/build_wheel_cuml.shci/build_wheel_libcuml.shci/test_cpp.shci/test_notebooks.shci/test_python_common.shci/test_wheel.shci/test_wheel_dask.shci/test_wheel_integrations.sh
389a1d0 to
e6889dc
Compare
|
Actionable comments posted: 0 |
|
/merge |
This PR swaps in
rapids-artifact-nameforrapids-package-nameeverywhere, and also removes any legacy named artifacts. All artifacts now follow the same naming convention (and that convention can be updated/expanded from a central location). Part of rapidsai/build-planning#270