Skip to content

Suppress intentional hardcoded version references - #8113

Merged
rockhowse merged 1 commit into
NVIDIA:mainfrom
csadorf:fix/verify-hardcoded-version
May 15, 2026
Merged

Suppress intentional hardcoded version references#8113
rockhowse merged 1 commit into
NVIDIA:mainfrom
csadorf:fix/verify-hardcoded-version

Conversation

@csadorf

@csadorf csadorf commented May 15, 2026

Copy link
Copy Markdown
Contributor

Adds explicit verify-hardcoded-version suppressions for intentional 26.08 deprecation, docstring, and TODO references so the all-files pre-commit check passes after the version update.

@csadorf
csadorf requested a review from a team as a code owner May 15, 2026 14:19
@csadorf
csadorf requested a review from dantegd May 15, 2026 14:19
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 15, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 15, 2026
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a57c1c80-ba46-4cbc-b3fb-517bd626dba8

📥 Commits

Reviewing files that changed from the base of the PR and between 7f72715 and 5ac4359.

📒 Files selected for processing (18)
  • python/cuml/cuml/dask/ensemble/base.py
  • python/cuml/cuml/dask/ensemble/randomforestclassifier.py
  • python/cuml/cuml/dask/ensemble/randomforestregressor.py
  • python/cuml/cuml/ensemble/randomforest_common.pyx
  • python/cuml/cuml/ensemble/randomforestclassifier.py
  • python/cuml/cuml/ensemble/randomforestregressor.py
  • python/cuml/tests/dask/test_dask_random_forest.py
  • python/cuml/tests/explainer/test_explainer_common.py
  • python/cuml/tests/explainer/test_explainer_kernel_shap.py
  • python/cuml/tests/explainer/test_gpu_treeshap.py
  • python/cuml/tests/test_api.py
  • python/cuml/tests/test_base.py
  • python/cuml/tests/test_common.py
  • python/cuml/tests/test_fil.py
  • python/cuml/tests/test_meta_estimators.py
  • python/cuml/tests/test_pickle.py
  • python/cuml/tests/test_random_forest.py
  • python/cuml/tests/test_sklearn_compatibility.py

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Internal code quality improvements through linting configuration updates across multiple modules and test files. No changes to functionality, behavior, or public APIs.

Walkthrough

This PR adds rapids-pre-commit-hooks: disable-next-line comment directives across RandomForest implementation modules and test files to suppress specific lint checks on lines containing FutureWarnings, documentation blocks, and pytest decorators, without modifying functional code or test behavior.

Changes

Pre-commit hook lint suppressions

Layer / File(s) Summary
RandomForest module lint suppressions
python/cuml/cuml/dask/ensemble/base.py, python/cuml/cuml/dask/ensemble/randomforestclassifier.py, python/cuml/cuml/dask/ensemble/randomforestregressor.py, python/cuml/cuml/ensemble/randomforest_common.pyx, python/cuml/cuml/ensemble/randomforestclassifier.py, python/cuml/cuml/ensemble/randomforestregressor.py
Disable-next-line comments added in worker selection, FutureWarning blocks for deprecated max_depth defaults, and class docstrings across dask and non-dask RandomForest implementations.
Test file lint suppressions
python/cuml/tests/dask/test_dask_random_forest.py, python/cuml/tests/explainer/test_explainer_common.py, python/cuml/tests/explainer/test_explainer_kernel_shap.py, python/cuml/tests/explainer/test_gpu_treeshap.py, python/cuml/tests/test_api.py, python/cuml/tests/test_base.py, python/cuml/tests/test_common.py, python/cuml/tests/test_fil.py, python/cuml/tests/test_meta_estimators.py, python/cuml/tests/test_pickle.py, python/cuml/tests/test_random_forest.py, python/cuml/tests/test_sklearn_compatibility.py
Disable-next-line comments added near import blocks and pytest decorator areas across 12 test files to suppress pre-commit hook checks; test logic remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cuml#7958: Introduces FutureWarning for deprecated max_depth default behavior and documentation changes in RandomForest modules; this PR adds lint suppressions around those same warning and documentation areas.

Suggested labels

Cython / Python

Suggested reviewers

  • dantegd
  • jameslamb
  • msarahan
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Suppress intentional hardcoded version references' directly and accurately describes the main change: adding suppressions for hardcoded version references across multiple files.
Description check ✅ Passed The description clearly explains the purpose of the changes: adding explicit suppressions for intentional version references to enable pre-commit checks to pass.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf

csadorf commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Can be reverted after rapidsai/pre-commit-hooks#124 is resolved.

@rockhowse
rockhowse merged commit 2a2e844 into NVIDIA:main May 15, 2026
66 of 75 checks passed
@csadorf
csadorf deleted the fix/verify-hardcoded-version branch May 18, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants