Skip to content

Update libcuml wheel to depend on librmm - #8110

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.06from
jcrist:libcuml-depend-on-librmm
May 15, 2026
Merged

Update libcuml wheel to depend on librmm#8110
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.06from
jcrist:libcuml-depend-on-librmm

Conversation

@jcrist

@jcrist jcrist commented May 15, 2026

Copy link
Copy Markdown
Member

This is required to import libcuml, but wasn't explicitly listed as a dependency. The parent main user-facing package (cuml) does have a rmm dependency, which in turn depends on librmm, so everything would be installed properly normally anyway. Just adding an explicit link here for tidyness.

Part of #7845.

This is required to import `libcuml`, but wasn't explicitly listed as a
dependency. The parent main user-facing package (`cuml`) does have a
`rmm` dependency, which in turn depends on `librmm`, so everything would
be installed properly normally anyway. Just adding an explicit link here
for tidyness.
@jcrist jcrist self-assigned this May 15, 2026
@jcrist
jcrist requested a review from a team as a code owner May 15, 2026 00:06
@jcrist
jcrist requested a review from msarahan May 15, 2026 00:06
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 15, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 15, 2026
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 10877aaa-70fd-4bf3-9b23-1b55a82361a9

📥 Commits

Reviewing files that changed from the base of the PR and between ed84506 and a9926b1.

📒 Files selected for processing (2)
  • dependencies.yaml
  • python/libcuml/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated libcuml dependency configuration to include librmm package (version 26.6.*).

Walkthrough

This PR adds librmm as an explicit runtime dependency for the libcuml Python package. The change is declared in pyproject.toml with a pinned version 26.6.* and is registered in the build configuration via dependencies.yaml.

Changes

librmm Dependency Addition

Layer / File(s) Summary
Add librmm dependency to libcuml
python/libcuml/pyproject.toml, dependencies.yaml
Added librmm==26.6.*,>=0.0.0a0 to the package dependencies list in pyproject.toml and added depends_on_librmm to the py_run_libcuml includes in dependencies.yaml to establish the runtime dependency declaration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cuml#7879: Both PRs update python/libcuml/pyproject.toml's librmm dependency declarations to the 26.06 line (main PR further adds librmm to runtime deps and updates dependencies.yaml via depends_on_librmm).

Suggested labels

Cython / Python

Suggested reviewers

  • bdice
  • divyegala
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding an explicit librmm dependency to the libcuml wheel package.
Description check ✅ Passed The description is related to the changeset, explaining the rationale for adding the librmm dependency and referencing the related issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jcrist

jcrist commented May 15, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 54b6e3f into NVIDIA:release/26.06 May 15, 2026
105 checks passed
@jcrist
jcrist deleted the libcuml-depend-on-librmm branch May 15, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants