-
Notifications
You must be signed in to change notification settings - Fork 662
Support LabelEncoder in cuml.accel
#8082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
python/cuml/cuml/accel/_patches/sklearn/utils/discovery.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| import functools | ||
| from collections import defaultdict | ||
| from operator import itemgetter | ||
|
|
||
| from sklearn.utils.discovery import all_estimators as _all_estimators | ||
|
|
||
| from cuml.accel.estimator_proxy import is_proxy | ||
|
|
||
| __all__ = ("all_estimators",) | ||
|
|
||
|
|
||
| @functools.wraps(_all_estimators) | ||
| def all_estimators(*args, **kwargs): | ||
| # This function replaces sklearn's all_estimators function with a version | ||
| # that filters out duplicate estimator names, keeping only proxy estimators | ||
| # when both proxy and non-proxy versions exist. | ||
| # | ||
| # When the accelerator is installed, sklearn's all_estimators() returns | ||
| # duplicate entries for the same estimator name (e.g., LinearSVC appears | ||
| # both with sklearn.svm.LinearSVC and sklearn._classes.LinearSVC). This causes | ||
| # a TypeError during test collection when sklearn tries to sort the | ||
| # estimators as it attempts to sort based on the type. | ||
|
|
||
| # Obtain the list of all estimators from sklearn | ||
| ret = _all_estimators(*args, **kwargs) | ||
|
|
||
| # Group estimators by name | ||
| estimator_groups = defaultdict(list) | ||
| for name, cls in ret: | ||
| estimator_groups[name].append(cls) | ||
|
|
||
| # Drop non-proxies wherever there are multiple classes with the same name | ||
| estimators = [] | ||
| for name, cls_list in estimator_groups.items(): | ||
| if len(cls_list) == 1: | ||
| estimators.append((name, cls_list[0])) | ||
| else: | ||
| proxied_cls = [cls for cls in cls_list if is_proxy(cls)] | ||
| assert len(proxied_cls) == 1 | ||
| estimators.append((name, proxied_cls[0])) | ||
|
|
||
| # Return the sorted list of estimators like the original | ||
| return sorted(set(estimators), key=itemgetter(0)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.