Skip to content

Remove stale KMeans accel xfails - #8068

Closed
csadorf wants to merge 1 commit into
mainfrom
fix/kmeans-accel-xpass
Closed

Remove stale KMeans accel xfails#8068
csadorf wants to merge 1 commit into
mainfrom
fix/kmeans-accel-xpass

Conversation

@csadorf

@csadorf csadorf commented May 8, 2026

Copy link
Copy Markdown
Contributor

Removes stale scikit-learn 1.6 KMeans predict xfails from the cuml.accel upstream xfail list.

@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 8, 2026
@csadorf
csadorf requested a review from a team as a code owner May 8, 2026 02:56
@csadorf
csadorf requested a review from dantegd May 8, 2026 02:56
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 8, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 8, 2026
@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fd8dfecb-c4c7-411d-916c-339db23d711f

📥 Commits

Reviewing files that changed from the base of the PR and between aed66d5 and a98427b.

📒 Files selected for processing (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-list.yaml
💤 Files with no reviewable changes (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-list.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated test configuration for scikit-learn version compatibility adjustments.

Walkthrough

The xfail list for cuml.accel tests is updated to change the scikit-learn version condition for the KMeans repeated predict output deviation tests from >=1.6 to <1.6, affecting when these four test cases are expected to fail.

Changes

Test XFail Configuration

Layer / File(s) Summary
XFail Condition Update
python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-list.yaml
The cuml_accel_kmeans_repeated_predict_output_deviation xfail condition is changed from scikit-learn>=1.6 to scikit-learn<1.6, adjusting the version gate for the same four KMeans repeated predict test cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

tests

Suggested reviewers

  • dantegd
  • viclafargue
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing outdated KMeans acceleration expected failures from the xfail list.
Description check ✅ Passed The description is directly related to the changeset, explaining that stale scikit-learn 1.6 KMeans predict xfails are being removed from the cuml.accel upstream xfail list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/kmeans-accel-xpass

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf csadorf mentioned this pull request May 8, 2026
@csadorf

csadorf commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

Fix was included with #8039 .

@csadorf csadorf closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants