Repository navigation
Adopt nvForest for random forest inference #8048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 52 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
8e62fb1
Add nvforest as dependency
chyunsu3 f826bc2
Remove FIL; add nvForest to CMake
chyunsu3 4142a2c
Link nvforest if LINK_NVFOREST=1
chyunsu3 8cd428f
Remove cuml/forest headers
chyunsu3 8d5c2b9
Remove cuml.fil from Python
chyunsu3 bc7212f
Add compatibility layer for cuml.fil
chyunsu3 dbc47b2
Use nvForest in cuML RF
chyunsu3 2b64436
Update pytests; remove FIL from benchmark
chyunsu3 c11194d
Update test_fil.py
chyunsu3 8b188b6
Update pytests
chyunsu3 35107c2
Merge remote-tracking branch 'origin/main' into adopt_nvforest
chyunsu3 f17cd37
Merge remote-tracking branch 'origin/main' into adopt_nvforest
chyunsu3 1a8ada3
Add libnvforest as dep for gtest
chyunsu3 080e9bd
Add nvforest to Conda recipe
chyunsu3 fee06a1
Merge remote-tracking branch 'origin/main' into adopt_nvforest
chyunsu3 605847e
Address review comments by coderabbitai
chyunsu3 310c27e
Revert changes to test_random_forest.py
chyunsu3 4a9499e
Revert changes to test_random_forest.py
chyunsu3 72acfac
Fix test_random_forest.py
chyunsu3 c883107
Use convert_dtype arg
chyunsu3 4cfdc08
Revert changes to test_fil.py
chyunsu3 ac1a870
Revert changes to test_fil.py
chyunsu3 ace3579
Fix up compat layer for FIL
chyunsu3 4db26c0
Set convert_dtype=True before passing array to nvForest
chyunsu3 a27e367
Document of removal of FIL in 26.10
chyunsu3 236c320
Fix FIL attributes
chyunsu3 b7efba9
Filter libnvforest++.so in auditwheel
chyunsu3 285da42
Merge remote-tracking branch 'origin/main' into adopt_nvforest
chyunsu3 a4034a2
Fix pytests
chyunsu3 1f2bcdc
Address review comments from coderabbitai
chyunsu3 6b4ad22
Address review comments from coderabbitai
chyunsu3 7819494
Fix pytests
chyunsu3 93b2099
Save suppress_deprecation_warning
chyunsu3 3b68c17
Address review comments from coderabbitai
chyunsu3 9040db0
Merge branch 'main' into adopt_nvforest
chyunsu3 0f84607
Merge remote-tracking branch 'origin/main' into adopt_nvforest
chyunsu3 60b57e6
Merge remote-tracking branch 'origin/main' into adopt_nvforest
chyunsu3 d705cb8
Load libnvforest first in wheel
chyunsu3 7cafa13
Merge remote-tracking branch 'origin/main' into adopt_nvforest
chyunsu3 a121230
Merge remote-tracking branch 'origin/release/26.06' into adopt_nvforest
chyunsu3 726ecde
Address review comments about input validation
chyunsu3 8abf045
Merge remote-tracking branch 'origin/release/26.06' into adopt_nvforest
chyunsu3 0b5c203
Add deprecation notice
chyunsu3 c4f7800
Emit warning for set_fil_device_type
chyunsu3 28619f5
Add back as_fil()
chyunsu3 5df218e
Merge branch 'release/26.06' into adopt_nvforest
chyunsu3 44cc3b7
Add missing import
chyunsu3 e3975a3
Fix pytests
chyunsu3 26842e2
Address reviewer's comments
chyunsu3 1ef4a77
Correctly handle case where treelite_model is bytes
chyunsu3 6c360ec
Turn FIL.rst into a stub
chyunsu3 7438c88
Fix rst syntax
chyunsu3 8ff774a
Update DEPENDENCIES
chyunsu3 c7f90af
Address reviewer comments
chyunsu3 2bdc95c
Merge remote-tracking branch 'origin/release/26.06' into adopt_nvforest
chyunsu3 fab3c3c
Alphabetize wheel library excludes
csadorf f1ae0ca
Centralize nvForest CMake target name
csadorf ff1a636
Address nvForest test review nits
csadorf 6eba05b
Align RF as_fil deprecation docs
csadorf c51b0c3
Reuse cached nvForest model for RF OOB scoring
csadorf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.