Skip to content

Add -v option to timeout in CI scripts - #7966

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jcrist:add-verbose-to-timeout
Apr 8, 2026
Merged

Add -v option to timeout in CI scripts#7966
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jcrist:add-verbose-to-timeout

Conversation

@jcrist

@jcrist jcrist commented Apr 8, 2026

Copy link
Copy Markdown
Member

This better indicates when timeout kills a command, rather than the logs just mysteriously stopping.

Fixes #7964.

This better indicates when `timeout` kills a command, rather than the
logs just mysteriously stopping.
@jcrist
jcrist requested a review from a team as a code owner April 8, 2026 20:33
@jcrist
jcrist requested a review from gforsyth April 8, 2026 20:33
@github-actions github-actions Bot added the ci label Apr 8, 2026
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed ci labels Apr 8, 2026
@coderabbitai

coderabbitai Bot commented Apr 8, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8847838-aeb7-400c-8bbd-0bfa997a32ae

📥 Commits

Reviewing files that changed from the base of the PR and between 3420d7f and 3368bbc.

📒 Files selected for processing (6)
  • ci/test_cpp.sh
  • ci/test_python_cuml_accel_upstream.sh
  • ci/test_python_dask.sh
  • ci/test_wheel.sh
  • ci/test_wheel_dask.sh
  • ci/test_wheel_integrations.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Enhanced CI test execution with improved timeout diagnostic output across multiple test suites.

Walkthrough

Six CI shell scripts updated to add verbose output (-v flag) to timeout commands for improved logging during mid-run failures. SPDX copyright year headers updated to 2026 in affected files.

Changes

Cohort / File(s) Summary
C++ Test Execution
ci/test_cpp.sh
Added -v flag to timeout command for run_ctests.sh invocation; updated copyright year to 2026.
Python UMAP Test Execution
ci/test_python_cuml_accel_upstream.sh
Added -v flag to timeout command for UMAP test runner; updated copyright header year range to 2025-2026.
Dask Test Execution
ci/test_python_dask.sh, ci/test_wheel_dask.sh
Added -v flag to timeout commands for Dask pytest invocations (both no-UCXX and UCXX-only runs).
Single-GPU Wheel Test Execution
ci/test_wheel.sh
Added -v flag to two timeout invocations for single-GPU pytest runs (main suite and test_sparse_pca_inputs subset).
Integration Test Execution
ci/test_wheel_integrations.sh
Added -v flag to timeout command for BERTopic end-to-end smoke test invocation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

improvement, non-breaking, ci

Suggested reviewers

  • AyodeAwe
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR contains scope-related changes: copyright year updates from 2025 to 2026 in some files, which are outside the stated objective of improving timeout logging. Remove copyright year updates to 2026 from ci/test_cpp.sh and ci/test_python_cuml_accel_upstream.sh, or include them in the PR description if intentional.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'Add -v option to timeout in CI scripts' clearly and accurately describes the primary change in the changeset.
Description check ✅ Passed The description explains the purpose of adding the -v option to timeout commands and references the related issue #7964, which is related to the changeset.
Linked Issues check ✅ Passed The PR successfully implements the logging improvement requested in issue #7964 by adding verbose output to timeout commands across CI scripts, making timeout-related terminations visible in logs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jcrist

jcrist commented Apr 8, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit de94966 into NVIDIA:main Apr 8, 2026
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Improve logging for cases that might cause mid-run failures

4 participants