Skip to content

Disable SciPy intersphinx - #7935

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.04from
jcrist:disable-scipy-intersphinx
Mar 31, 2026
Merged

Disable SciPy intersphinx#7935
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.04from
jcrist:disable-scipy-intersphinx

Conversation

@jcrist

@jcrist jcrist commented Mar 31, 2026

Copy link
Copy Markdown
Member

The scipy docs site has some reliability issues, and can sometimes cause our docs to fail to build. While they're resolving this, we'll disable scipy intersphinx mappings. We rarely make use of scipy intersphinx mappings anyway, so this won't be a huge docs UX degradation.

The scipy docs site has some reliability issues, and can sometimes cause
our docs to fail to build. While they're resolving this, we'll disable
scipy intersphinx mappings. We rarely make use of scipy intersphinx
mappings anyway, so this won't be a huge docs UX degradation.
@jcrist
jcrist requested a review from a team as a code owner March 31, 2026 16:41
@jcrist
jcrist requested a review from dantegd March 31, 2026 16:41
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 31, 2026
@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b573dbf-e23e-4288-8a75-6a5db1d7a4b2

📥 Commits

Reviewing files that changed from the base of the PR and between 10be112 and 5a5696d.

📒 Files selected for processing (1)
  • docs/source/conf.py

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated documentation cross-reference configuration to streamline external library linking in generated documentation.

Walkthrough

The change disables the scipy documentation mapping in the Sphinx configuration by commenting it out rather than removing it entirely, leaving cudf, numpy, python, and sklearn as the active intersphinx mappings.

Changes

Cohort / File(s) Summary
Sphinx Configuration
docs/source/conf.py
Commented out the scipy entry in intersphinx_mapping, reducing active documentation mappings to cudf, numpy, python, and sklearn.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Disable SciPy intersphinx' directly and clearly describes the main change in the pull request, which is disabling the SciPy intersphinx mapping.
Description check ✅ Passed The description explains the reason for disabling SciPy intersphinx (reliability issues with scipy docs site) and addresses the impact, which is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jcrist jcrist added DO NOT MERGE Hold off on merging; see PR for details and removed DO NOT MERGE Hold off on merging; see PR for details labels Mar 31, 2026
@jcrist

jcrist commented Mar 31, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 8cf29e1 into NVIDIA:release/26.04 Mar 31, 2026
60 checks passed
@jcrist
jcrist deleted the disable-scipy-intersphinx branch March 31, 2026 17:08
rapids-bot Bot pushed a commit to rapidsai/nvforest that referenced this pull request Mar 31, 2026
Yesterday's nightly build on `main` failed like this:

> loading intersphinx inventory 'scipy' from https://docs.scipy.org/doc/scipy/objects.inv ...
loading intersphinx inventory 'sklearn' from https://scikit-learn.org/stable/objects.inv ...
loading intersphinx inventory 'treelite' from https://treelite.readthedocs.io/en/latest/objects.inv ...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.scipy.org/doc/scipy/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectTimeout'>: HTTPSConnectionPool(host='docs.scipy.org', port=443): Max retries exceeded with url: /doc/scipy/objects.inv (Caused by ConnectTimeoutError(<HTTPSConnection(host='docs.scipy.org', port=443) at 0x7a5853ca11d0>, 'Connection to docs.scipy.org timed out. (connect timeout=None)'))
building [mo]: targets for 0 po files that are out of date

([build link](https://github.com/rapidsai/nvforest/actions/runs/23783492846/job/69301772677))

Because of docs-hosting issues with scipy:

* scipy/scipy#24950
* scipy/docs.scipy.org#102

This PR removes `intersphinx` configuration for `cudf` and `scipy`... nvForest doesn't use either, and removing those reduces the risk of similar failures in the future.

Similar to NVIDIA/cuml#7935

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Jim Crist-Harif (https://github.com/jcrist)
  - Bradley Dice (https://github.com/bdice)

URL: #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants