Skip to content

Remove no_bad_cuml_array_check - #7887

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.04from
csadorf:remove-no-bad-cuml-array-check
Mar 16, 2026
Merged

Remove no_bad_cuml_array_check#7887
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.04from
csadorf:remove-no-bad-cuml-array-check

Conversation

@csadorf

@csadorf csadorf commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Closes #3148

@csadorf
csadorf requested review from a team as code owners March 13, 2026 16:34
@csadorf
csadorf requested review from msarahan and viclafargue March 13, 2026 16:34
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Mar 13, 2026
@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e4f75aaa-c921-4e92-a536-ae6e29d3da34

📥 Commits

Reviewing files that changed from the base of the PR and between c3a5f52 and c6e368f.

📒 Files selected for processing (2)
  • python/cuml/pyproject.toml
  • python/cuml/tests/test_incremental_pca.py
💤 Files with no reviewable changes (2)
  • python/cuml/tests/test_incremental_pca.py
  • python/cuml/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Tests

    • Removed special test markers and decorators to simplify test execution and reduce conditional gating.
    • Incremental PCA tests now run without prior marker-based exclusions, streamlining test behavior.
  • Chores

    • Cleaned up test configuration to improve maintainability and reduce setup complexity.

Walkthrough

Removed the deprecated no_bad_cuml_array_check pytest marker from project configuration and from test decorators in python/cuml/tests/test_incremental_pca.py; no other functional changes were made.

Changes

Cohort / File(s) Summary
Marker Definition
python/cuml/pyproject.toml
Removed the no_bad_cuml_array_check entry from the pytest markers list.
Test Decorators
python/cuml/tests/test_incremental_pca.py
Removed no_bad_cuml_array_check pytest marker decorators from test_fit and test_partial_fit.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • msarahan
  • divyegala
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the primary change: removing the no_bad_cuml_array_check marker.
Description check ✅ Passed The description references the linked issue #3148 which directly addresses the marker removal objective.
Linked Issues check ✅ Passed The PR successfully removes the marker from both the pyproject.toml configuration file and the two tests in test_incremental_pca.py as required by issue #3148.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the no_bad_cuml_array_check marker as specified in issue #3148; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@csadorf csadorf added tests Unit testing for project improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 13, 2026
@jcrist
jcrist changed the base branch from main to release/26.04 March 16, 2026 18:34
@jcrist
jcrist requested a review from a team as a code owner March 16, 2026 18:34
@jcrist
jcrist force-pushed the remove-no-bad-cuml-array-check branch from cefb14c to c6e368f Compare March 16, 2026 18:37

@jcrist jcrist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this onto release/26.04, should be good-to-go.

@jcrist

jcrist commented Mar 16, 2026

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 8f233f2 into NVIDIA:release/26.04 Mar 16, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Remove no_bad_cuml_array_check Marker from PyTest

6 participants