Remove deprecated tree_method=gpu_hist with XGBoost - #7858
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes replace deprecated XGBoost Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@python/cuml/cuml/experimental/hyperparams/HPO_demo.ipynb`:
- Around line 764-767: The notebook text claims CPU mode runs below 1% but the
code uses the variable data_fraction with a guard data_fraction <= 0.1 (10%);
make them consistent by either updating the explanatory markdown to state "10%"
or changing the conditional to use 0.01 (1%) so the runtime guard matches the
text; locate the check that references data_fraction and the nearby markdown
paragraph describing the CPU threshold and update one of them so both reflect
the same percentage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f6b9a157-07a5-4712-991b-8e2fd5aeac73
📒 Files selected for processing (3)
notebooks/target_encoder_walkthrough.ipynbpython/cuml/cuml/benchmark/bench_helper_funcs.pypython/cuml/cuml/experimental/hyperparams/HPO_demo.ipynb
| "Now, running the model in CPU version to notice the difference in performance in terms of time. The main difference you would notice is that the `device` is set to `cpu` instead of `cuda`. The interface remains the same and we can even make use of the same parameters that we defined earlier (in fact, this is necessary for a fair comparison). \n", | ||
| "\n", | ||
| "Note: Remember the `data_fraction` flag from earlier and we will ensure we only run the CPU version if we are using less than 1% of the data" | ||
| ] |
There was a problem hiding this comment.
CPU threshold text is inconsistent with the code guard.
Line 764 says CPU mode should run below 1%, but Line 795 uses data_fraction <= 0.1 (10%). Please align the text or condition to avoid misleading notebook users.
🛠️ Suggested markdown fix
- "Now, running the model in CPU version to notice the difference in performance in terms of time. The main difference you would notice is that the `device` is set to `cpu` instead of `cuda`. The interface remains the same and we can even make use of the same parameters that we defined earlier (in fact, this is necessary for a fair comparison). \n",
+ "Now, running the model in CPU version to notice the difference in performance in terms of time. The main difference you would notice is that the `device` is set to `cpu` instead of `cuda`. The interface remains the same and we can even make use of the same parameters that we defined earlier (in fact, this is necessary for a fair comparison). \n",
- "Note: Remember the `data_fraction` flag from earlier and we will ensure we only run the CPU version if we are using less than 1% of the data"
+ "Note: Remember the `data_fraction` flag from earlier and we will ensure we only run the CPU version if we are using 10% of the data or less"As per coding guidelines, notebook examples and guidance should remain accurate and aligned with executable behavior.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Now, running the model in CPU version to notice the difference in performance in terms of time. The main difference you would notice is that the `device` is set to `cpu` instead of `cuda`. The interface remains the same and we can even make use of the same parameters that we defined earlier (in fact, this is necessary for a fair comparison). \n", | |
| "\n", | |
| "Note: Remember the `data_fraction` flag from earlier and we will ensure we only run the CPU version if we are using less than 1% of the data" | |
| ] | |
| "Now, running the model in CPU version to notice the difference in performance in terms of time. The main difference you would notice is that the `device` is set to `cpu` instead of `cuda`. The interface remains the same and we can even make use of the same parameters that we defined earlier (in fact, this is necessary for a fair comparison). \n", | |
| "\n", | |
| "Note: Remember the `data_fraction` flag from earlier and we will ensure we only run the CPU version if we are using 10% of the data or less" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@python/cuml/cuml/experimental/hyperparams/HPO_demo.ipynb` around lines 764 -
767, The notebook text claims CPU mode runs below 1% but the code uses the
variable data_fraction with a guard data_fraction <= 0.1 (10%); make them
consistent by either updating the explanatory markdown to state "10%" or
changing the conditional to use 0.01 (1%) so the runtime guard matches the text;
locate the check that references data_fraction and the nearby markdown paragraph
describing the CPU threshold and update one of them so both reflect the same
percentage.
|
/merge |
Closes #7191