Bump scipy minimum required version to 1.14.0. - #7857
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated minimum SciPy version from >=1.13.0 to >=1.14.0 across conda environment YAMLs, dependency manifests, documentation, and the Python package pyproject; also raised documented scikit-learn and treelite version constraints. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can use Clang for C/C++ static analysis and code quality checks.Clang provides comprehensive static analysis for C and C++ code, including syntax checking, type checking, and various warning diagnostics. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/source/supported_versions.rst (1)
13-19:⚠️ Potential issue | 🟠 MajorUpdate stale dependency version constraints in documentation.
The documentation lists outdated version requirements:
scikit-learn>=1.4should bescikit-learn>=1.5(per dependencies.yaml:330, pyproject.toml:96)treelite==4.4.1should betreelite>=4.6.1,<5.0.0(per dependencies.yaml:319, pyproject.toml:98)scipy>=1.14.0is correctProposed docs fix
* **NumPy**: >=1.23,<3.0a0 -* **scikit-learn**: >=1.4 +* **scikit-learn**: >=1.5 * **scipy**: >=1.14.0 * **numba**: >=0.60.0,<0.62.0a0 * **cupy**: cupy-cuda12x>=13.6.0 (CUDA 12), cupy-cuda13x>=13.6.0 (CUDA 13) -* **treelite**: ==4.4.1 +* **treelite**: >=4.6.1,<5.0.0🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/source/supported_versions.rst` around lines 13 - 19, Update the stale version constraints in the supported_versions list: change the scikit-learn entry from "scikit-learn: >=1.4" to "scikit-learn: >=1.5" and replace the treelite entry from "treelite: ==4.4.1" to "treelite: >=4.6.1,<5.0.0"; leave NumPy, scipy, numba and cupy entries unchanged. Locate and edit the lines containing the package names (e.g., the "scikit-learn" and "treelite" list items) in supported_versions.rst so they match the versions declared in dependencies.yaml and pyproject.toml.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@docs/source/supported_versions.rst`:
- Around line 13-19: Update the stale version constraints in the
supported_versions list: change the scikit-learn entry from "scikit-learn:
>=1.4" to "scikit-learn: >=1.5" and replace the treelite entry from "treelite:
==4.4.1" to "treelite: >=4.6.1,<5.0.0"; leave NumPy, scipy, numba and cupy
entries unchanged. Locate and edit the lines containing the package names (e.g.,
the "scikit-learn" and "treelite" list items) in supported_versions.rst so they
match the versions declared in dependencies.yaml and pyproject.toml.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e2bc87b0-1c15-47f4-9948-24f9e90bbaee
📒 Files selected for processing (7)
conda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-129_arch-x86_64.yamlconda/environments/all_cuda-131_arch-aarch64.yamlconda/environments/all_cuda-131_arch-x86_64.yamldependencies.yamldocs/source/supported_versions.rstpython/cuml/pyproject.toml
02c1454 to
92d908a
Compare
gforsyth
left a comment
There was a problem hiding this comment.
Also need to bump it in the recipe.yaml file (sorry that isn't covered by the dependency generator)
aa03cc4 to
b553761
Compare
|
Ope, nice catch. Should be updated now. |
|
/merge |
5a00a4d
into
NVIDIA:release/26.04
Addresses rapidsai/build-planning#247