Skip to content

Bump scipy minimum required version to 1.14.0. - #7857

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:release/26.04from
csadorf:bump-scipy-1.14.0
Mar 17, 2026
Merged

Bump scipy minimum required version to 1.14.0.#7857
rapids-bot[bot] merged 3 commits into
NVIDIA:release/26.04from
csadorf:bump-scipy-1.14.0

Conversation

@csadorf

@csadorf csadorf commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@csadorf
csadorf requested review from a team as code owners March 5, 2026 22:13
@csadorf
csadorf requested review from AyodeAwe and divyegala March 5, 2026 22:13
@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue labels Mar 5, 2026
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 5, 2026
@coderabbitai

coderabbitai Bot commented Mar 5, 2026

Copy link
Copy Markdown

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated minimum SciPy version from >=1.13.0 to >=1.14.0 across conda environment YAMLs, dependency manifests, documentation, and the Python package pyproject; also raised documented scikit-learn and treelite version constraints.

Changes

Cohort / File(s) Summary
Conda environment specs
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-129_arch-x86_64.yaml, conda/environments/all_cuda-131_arch-aarch64.yaml, conda/environments/all_cuda-131_arch-x86_64.yaml
Bumped scipy minimum from >=1.13.0 to >=1.14.0.
Dependency manifests
dependencies.yaml, python/cuml/pyproject.toml
Updated scipy requirement to >=1.14.0 in dependency declarations.
Documentation
docs/source/supported_versions.rst
Raised documented minimums: scipy to >=1.14.0, scikit-learn to >=1.5, and adjusted treelite to >=4.6.1,<5.0.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • bdice
  • divyegala
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: bumping scipy's minimum required version to 1.14.0, which is reflected across all modified dependency files.
Description check ✅ Passed The description references a specific GitHub issue that addresses the purpose of the changes, confirming the PR is related to updating scipy version requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Clang for C/C++ static analysis and code quality checks.

Clang provides comprehensive static analysis for C and C++ code, including syntax checking, type checking, and various warning diagnostics.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/source/supported_versions.rst (1)

13-19: ⚠️ Potential issue | 🟠 Major

Update stale dependency version constraints in documentation.

The documentation lists outdated version requirements:

  • scikit-learn>=1.4 should be scikit-learn>=1.5 (per dependencies.yaml:330, pyproject.toml:96)
  • treelite==4.4.1 should be treelite>=4.6.1,<5.0.0 (per dependencies.yaml:319, pyproject.toml:98)
  • scipy>=1.14.0 is correct
Proposed docs fix
 * **NumPy**: >=1.23,<3.0a0
-* **scikit-learn**: >=1.4
+* **scikit-learn**: >=1.5
 * **scipy**: >=1.14.0
 * **numba**: >=0.60.0,<0.62.0a0
 * **cupy**: cupy-cuda12x>=13.6.0 (CUDA 12), cupy-cuda13x>=13.6.0 (CUDA 13)
-* **treelite**: ==4.4.1
+* **treelite**: >=4.6.1,<5.0.0
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/supported_versions.rst` around lines 13 - 19, Update the stale
version constraints in the supported_versions list: change the scikit-learn
entry from "scikit-learn: >=1.4" to "scikit-learn: >=1.5" and replace the
treelite entry from "treelite: ==4.4.1" to "treelite: >=4.6.1,<5.0.0"; leave
NumPy, scipy, numba and cupy entries unchanged. Locate and edit the lines
containing the package names (e.g., the "scikit-learn" and "treelite" list
items) in supported_versions.rst so they match the versions declared in
dependencies.yaml and pyproject.toml.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@docs/source/supported_versions.rst`:
- Around line 13-19: Update the stale version constraints in the
supported_versions list: change the scikit-learn entry from "scikit-learn:
>=1.4" to "scikit-learn: >=1.5" and replace the treelite entry from "treelite:
==4.4.1" to "treelite: >=4.6.1,<5.0.0"; leave NumPy, scipy, numba and cupy
entries unchanged. Locate and edit the lines containing the package names (e.g.,
the "scikit-learn" and "treelite" list items) in supported_versions.rst so they
match the versions declared in dependencies.yaml and pyproject.toml.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e2bc87b0-1c15-47f4-9948-24f9e90bbaee

📥 Commits

Reviewing files that changed from the base of the PR and between 1e6dfb7 and f917177.

📒 Files selected for processing (7)
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • conda/environments/all_cuda-131_arch-aarch64.yaml
  • conda/environments/all_cuda-131_arch-x86_64.yaml
  • dependencies.yaml
  • docs/source/supported_versions.rst
  • python/cuml/pyproject.toml

@csadorf
csadorf changed the base branch from main to release/26.04 March 12, 2026 21:14
@csadorf
csadorf force-pushed the bump-scipy-1.14.0 branch from 02c1454 to 92d908a Compare March 13, 2026 16:31

@jcrist jcrist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to bump it in the recipe.yaml file (sorry that isn't covered by the dependency generator)

@jcrist
jcrist force-pushed the bump-scipy-1.14.0 branch from aa03cc4 to b553761 Compare March 16, 2026 21:39
@jcrist

jcrist commented Mar 16, 2026

Copy link
Copy Markdown
Member

Ope, nice catch. Should be updated now.

@jcrist

jcrist commented Mar 16, 2026

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 5a00a4d into NVIDIA:release/26.04 Mar 17, 2026
182 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants