[WIP] Implement new validation utilities - #7855
Closed
jcrist wants to merge 9 commits into
Closed
Conversation
jcrist
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
Superseded by #7973. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
cuml.internals.validationmodule with a new set of validation functions that estimators should use to validate inputs. These raise nicer error messages, are more compatible with expected sklearn UX, and put in place the plumbing necessary to expand our compatibility and checks.In this PR I intend to add only shape/ndim checks on the inputs (as well as
check_is_fittedchecks). There are a number of additional validations we should add, but those can be done in a followup.This PR is currently a WIP - pushing it up for now, but we still need to grind through updating the remaining estimators.
Supersedes #7816. Supersedes #7847. Fixes #7428.