Skip to content

Test CI with raft #2939 - #7799

Closed
aamijar wants to merge 1 commit into
NVIDIA:mainfrom
aamijar:ci-test-raft
Closed

Test CI with raft #2939#7799
aamijar wants to merge 1 commit into
NVIDIA:mainfrom
aamijar:ci-test-raft

Conversation

@aamijar

@aamijar aamijar commented Feb 13, 2026

Copy link
Copy Markdown
Member

Testing with NVIDIA/raft#2939

@aamijar
aamijar requested a review from a team as a code owner February 13, 2026 17:03
@aamijar
aamijar requested a review from bdice February 13, 2026 17:03
@aamijar aamijar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 13, 2026
@coderabbitai

coderabbitai Bot commented Feb 13, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated RAFT integration configuration to enhance build options and dependency management for developers building from source.

Walkthrough

Modified RAFT integration configuration in the cmake build system. Updated the fork source from rapidsai to aamijar, changed the pinned tag to raft-deprecated-headers, and added CLONE_ON_PIN and NVTX parameters to the RAFT configuration invocation.

Changes

Cohort / File(s) Summary
RAFT CMake Configuration
cpp/cmake/thirdparty/get_raft.cmake
Updated fork source and pinned tag for RAFT integration; added CLONE_ON_PIN and NVTX configuration parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

improvement, non-breaking

Suggested reviewers

  • jcrist
  • divyegala
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change - testing CI with a specific raft PR (#2939) by updating the raft configuration fork and tag.
Description check ✅ Passed The description is related to the changeset, providing a reference to the upstream raft PR being tested.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@cpp/cmake/thirdparty/get_raft.cmake`:
- Around line 58-60: The RAFT configuration in the call to
find_and_configure_raft is pointing to a personal fork and feature branch;
update the FORK and PINNED_TAG arguments in the find_and_configure_raft(...)
invocation to use FORK rapidsai and PINNED_TAG ${rapids-cmake-checkout-tag}
instead of aamijar and raft-deprecated-headers so the build depends on the
upstream rapidsai repository and the correct checkout tag before merging.

Comment thread cpp/cmake/thirdparty/get_raft.cmake
@aamijar

aamijar commented Feb 25, 2026

Copy link
Copy Markdown
Member Author

NVIDIA/raft#2939 is merged.

@aamijar aamijar closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants