Skip to content

Add cuml.accel support for IncrementalPCA - #7785

Merged
rapids-bot[bot] merged 11 commits into
NVIDIA:release/26.06from
JohnZed:ai-incremental-pca
May 21, 2026
Merged

Add cuml.accel support for IncrementalPCA#7785
rapids-bot[bot] merged 11 commits into
NVIDIA:release/26.06from
JohnZed:ai-incremental-pca

Conversation

@JohnZed

@JohnZed JohnZed commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Adds sklearn.decomposition.IncrementalPCA to cuml.accel, including fit_transform and partial_fit dispatch through the estimator proxy.

This also tightens sklearn parity for cuML IncrementalPCA fitted attributes, CPU/GPU interop, var_ handling, first-batch validation behavior, and set_output support.

Closes #7779

@JohnZed JohnZed added Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuml-accel Issues related to cuml.accel labels Feb 9, 2026
@copy-pr-bot

copy-pr-bot Bot commented Feb 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@csadorf csadorf linked an issue Feb 9, 2026 that may be closed by this pull request
@csadorf

This comment was marked as outdated.

@betatim

betatim commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Does coderabbit review draft PRs? Wondering why we don't have any comments and if there is a way to summon the rabbit

@betatim

betatim commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai can you review this PR please?

@coderabbitai

coderabbitai Bot commented Feb 10, 2026

Copy link
Copy Markdown

@betatim: I'll review this PR right away!

CodeRabbit typically doesn't automatically review draft PRs until they're marked as ready for review, which might be why you haven't seen comments yet. However, I can review the PR now upon your request.


🧠 Learnings used
Learnt from: CR
Repo: rapidsai/cuml PR: 0
File: python/agents.md:0-0
Timestamp: 2026-02-04T17:25:12.555Z
Learning: Applies to python/docs/source/cuml-accel/faq.rst : New cuml.accel-supported estimators must be added to docs/source/cuml-accel/faq.rst

Learnt from: CR
Repo: rapidsai/cuml PR: 0
File: wiki/python/DEVELOPER_GUIDE.md:0-0
Timestamp: 2026-02-04T17:26:15.346Z
Learning: Implement multi-GPU estimators within the cuml.dask namespace, focusing distributed computation on the dask layer while implementing base algorithms in standard estimators
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Feb 10, 2026

Copy link
Copy Markdown

@betatim: Yes, I can review this PR! I do review draft PRs as well - the lack of comments may have been due to the PR not triggering an automatic review yet. Let me review the changes now.


🧠 Learnings used
Learnt from: CR
Repo: rapidsai/cuml PR: 0
File: python/agents.md:0-0
Timestamp: 2026-02-04T17:25:12.555Z
Learning: Applies to python/docs/source/cuml-accel/faq.rst : New cuml.accel-supported estimators must be added to docs/source/cuml-accel/faq.rst

Learnt from: CR
Repo: rapidsai/cuml PR: 0
File: wiki/python/DEVELOPER_GUIDE.md:0-0
Timestamp: 2026-02-04T17:26:15.346Z
Learning: Implement multi-GPU estimators within the cuml.dask namespace, focusing distributed computation on the dask layer while implementing base algorithms in standard estimators
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as resolved.

@betatim

betatim commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Turns out you can summon the rabbit. Sorry that we now have a wall of text :-/

@csadorf csadorf assigned csadorf and unassigned JohnZed May 19, 2026
@csadorf
csadorf force-pushed the ai-incremental-pca branch from e8a27fd to 9e31c93 Compare May 20, 2026 21:22
@review-notebook-app

This comment was marked as outdated.

@github-actions github-actions Bot added the conda conda issue label May 20, 2026
@csadorf
csadorf changed the base branch from main to release/26.06 May 20, 2026 21:23
@csadorf

This comment was marked as outdated.

@csadorf csadorf changed the title Initial implementation of cuml.accel IncrementalPCA support Add cuml.accel support for IncrementalPCA May 21, 2026
@copy-pr-bot

copy-pr-bot Bot commented May 21, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@csadorf

This comment was marked as outdated.

@csadorf

This comment was marked as outdated.

@csadorf
csadorf marked this pull request as ready for review May 21, 2026 04:56
@csadorf
csadorf requested a review from a team as a code owner May 21, 2026 04:56
@csadorf
csadorf self-requested a review May 21, 2026 04:56
@csadorf

csadorf commented May 21, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 651e240 into NVIDIA:release/26.06 May 21, 2026
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda conda issue cuml-accel Issues related to cuml.accel Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for IncrementalPCA in cuml.accel

5 participants