Add cuml.accel support for IncrementalPCA - #7785
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Does coderabbit review draft PRs? Wondering why we don't have any comments and if there is a way to summon the rabbit |
|
@coderabbitai can you review this PR please? |
|
CodeRabbit typically doesn't automatically review draft PRs until they're marked as ready for review, which might be why you haven't seen comments yet. However, I can review the PR now upon your request. 🧠 Learnings used✅ Actions performedReview triggered.
|
|
🧠 Learnings used✅ Actions performedReview triggered.
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Turns out you can summon the rabbit. Sorry that we now have a wall of text :-/ |
e8a27fd to
9e31c93
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
`batch_size_` remains a special case: sklearn only sets it inside `fit()`, not `partial_fit()`, so it needs an explicit presence check.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/merge |
Adds
sklearn.decomposition.IncrementalPCAtocuml.accel, includingfit_transformandpartial_fitdispatch through the estimator proxy.This also tightens sklearn parity for cuML
IncrementalPCAfitted attributes, CPU/GPU interop,var_handling, first-batch validation behavior, andset_outputsupport.Closes #7779