Remove deprecations from 26.02 - #7761
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR removes multiple deprecated features and their associated warnings across the cuml library: memory_utils from the public API, the TotalIters wrapper class in SVM, the y parameter from train_test_split, the nnd_* build parameters in UMAP, and related test coverage. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/merge |
This removes almost all the remaining deprecations (outside of NVIDIA#7751). The only one I didn't handle was deprecations in `TargetEncoder` since I couldn't figure out what the intended behavior was. Will leave that for others. Summary: - Removes deprecated `cuml.internals.memory_utils` module - Removes deprecated `TotalIters` for `cuml.svm` - Removes deprecated `y` parameter in `train_test_split` - Removes deprecated parameters to `UMAP` (fixes NVIDIA#7709) Authors: - Jim Crist-Harif (https://github.com/jcrist) - Simon Adorf (https://github.com/csadorf) Approvers: - Simon Adorf (https://github.com/csadorf) URL: NVIDIA#7761
This removes almost all the remaining deprecations (outside of #7751). The only one I didn't handle was deprecations in
TargetEncodersince I couldn't figure out what the intended behavior was. Will leave that for others.Summary:
cuml.internals.memory_utilsmoduleTotalItersforcuml.svmyparameter intrain_test_splitUMAP(fixes Remove checks for deprecatednnd_*build_kwdsin UMAP #7709)