Skip to content

Remove deprecations from 26.02 - #7761

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
jcrist:remove-deps-2602
Feb 4, 2026
Merged

Remove deprecations from 26.02#7761
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
jcrist:remove-deps-2602

Conversation

@jcrist

@jcrist jcrist commented Feb 4, 2026

Copy link
Copy Markdown
Member

This removes almost all the remaining deprecations (outside of #7751). The only one I didn't handle was deprecations in TargetEncoder since I couldn't figure out what the intended behavior was. Will leave that for others.

Summary:

@jcrist jcrist self-assigned this Feb 4, 2026
@jcrist jcrist added the improvement Improvement / enhancement to an existing function label Feb 4, 2026
@jcrist
jcrist requested a review from a team as a code owner February 4, 2026 01:56
@jcrist jcrist added the non-breaking Non-breaking change label Feb 4, 2026
@jcrist
jcrist requested a review from divyegala February 4, 2026 01:56
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Feb 4, 2026
@coderabbitai

coderabbitai Bot commented Feb 4, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed deprecated y parameter from train_test_split() function
    • Removed deprecated TotalIters class from SVM models
    • Removed memory_utils from public API namespace
    • Cleaned up legacy parameter handling and deprecation warnings in UMAP

Walkthrough

This PR removes multiple deprecated features and their associated warnings across the cuml library: memory_utils from the public API, the TotalIters wrapper class in SVM, the y parameter from train_test_split, the nnd_* build parameters in UMAP, and related test coverage.

Changes

Cohort / File(s) Summary
Memory utilities cleanup
cuml/internals/__init__.py, cuml/internals/memory_utils.py
Removed memory_utils from public API exports and eliminated module-level __getattr__ deprecation wrapper for set_global_output_type and using_output_type attributes. Updated copyright year to 2026.
UMAP build parameters
cuml/manifold/umap/umap.pyx
Removed deprecated nnd_* build parameter handling; replaced with direct knn_n_clusters/overlap_factor extraction, added validation (n_clusters >= 1, overlap_factor < n_clusters when n_clusters > 1), and removed deprecation warnings and legacy branching.
SVM deprecation removal
cuml/svm/svm_base.pyx
Removed TotalIters deprecated wrapper class, eliminated associated runtime warnings and deprecation logic in _params_to_cpu and _fit methods, simplified max_iter parameter handling.
train_test_split refactoring
cuml/model_selection/_split.py
Removed deprecated y parameter from function signature, eliminated all related docstring documentation, validation branches, and control flow handling.
Test suite updates
tests/test_reflection.py, tests/test_svm.py, tests/test_train_test_split.py
Removed test coverage for deprecated features: memory_utils deprecation warnings (test_deprecated_memory_utils), TotalIters wrapper usage, and y parameter handling in train_test_split (~146 lines removed).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove deprecations from 26.02' accurately reflects the main objective of the PR, which is to remove deprecated features introduced in version 26.02.
Description check ✅ Passed The description clearly outlines what deprecations are being removed (memory_utils, TotalIters, y parameter, UMAP parameters) and relates directly to the changeset.
Linked Issues check ✅ Passed The PR successfully addresses issue #7709 by removing deprecated nnd_* build_kwds handling and warnings from UMAP, plus removes other deprecations as stated in the PR description.
Out of Scope Changes check ✅ Passed All changes are within scope: memory_utils removal, TotalIters removal, y parameter removal, and UMAP deprecation handling are all explicitly listed as PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf

csadorf commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 2b41c1a into NVIDIA:main Feb 4, 2026
105 checks passed
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 17, 2026
This removes almost all the remaining deprecations (outside of NVIDIA#7751). The only one I didn't handle was deprecations in `TargetEncoder` since I couldn't figure out what the intended behavior was. Will leave that for others.

Summary:

- Removes deprecated `cuml.internals.memory_utils` module
- Removes deprecated `TotalIters` for `cuml.svm`
- Removes deprecated `y` parameter in `train_test_split`
- Removes deprecated parameters to `UMAP` (fixes NVIDIA#7709)

Authors:
  - Jim Crist-Harif (https://github.com/jcrist)
  - Simon Adorf (https://github.com/csadorf)

Approvers:
  - Simon Adorf (https://github.com/csadorf)

URL: NVIDIA#7761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove checks for deprecated nnd_* build_kwds in UMAP

4 participants