Skip to content

[REVIEW] Bump xgboost to 1.6.0 from 1.5.2 - #4777

Merged
rapids-bot[bot] merged 11 commits into
NVIDIA:branch-22.08from
galipremsagar:xgboost_bump
Jun 23, 2022
Merged

[REVIEW] Bump xgboost to 1.6.0 from 1.5.2#4777
rapids-bot[bot] merged 11 commits into
NVIDIA:branch-22.08from
galipremsagar:xgboost_bump

Conversation

@galipremsagar

@galipremsagar galipremsagar commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Rapids recently bumped the xgbooot to 1.6.0 from 1.5.2 in: rapidsai/integration#487, this PR adapts to those recent changes.

@galipremsagar
galipremsagar requested a review from a team as a code owner June 13, 2022 20:37
@github-actions github-actions Bot added the gpuCI gpuCI issue label Jun 13, 2022
@galipremsagar galipremsagar added bug Something isn't working breaking Breaking change labels Jun 13, 2022
@trivialfis

trivialfis commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Hi, the latest release is 1.6.1

@galipremsagar

galipremsagar commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

@galipremsagar

galipremsagar commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi, the latest release is 1.6.1

I think ops will have to build for that version, so I feel the scope of this PR to be inline with version in the integration repo: https://github.com/rapidsai/integration/blob/branch-22.08/conda/recipes/versions.yaml#L12

cc: @rapidsai/ops-codeowners

@cjnolet

cjnolet commented Jun 15, 2022

Copy link
Copy Markdown
Collaborator

@gpucibot merge

@galipremsagar

galipremsagar commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

@cjnolet are these timeouts normal: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2439/testReport/junit/cuml.tests/test_fil/test_lightgbm_0_5_/?

@galipremsagar

galipremsagar commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

@cjnolet

cjnolet commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

@trivialfis @canonizer have you seen these timeouts before?

@trivialfis

trivialfis commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

No, that's from a lightgbm test?

@cjnolet

cjnolet commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

@trivialfis yeah, strangely. And it's also happening in a few nearest neighbors tests.

Tagging @wphicks also for any ideas.

@bdice bdice mentioned this pull request Jun 17, 2022
Merged
@galipremsagar

galipremsagar commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

@galipremsagar
galipremsagar requested a review from a team as a code owner June 21, 2022 15:32
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 21, 2022
@cjnolet

cjnolet commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

Looks like skipping all the pytests that use xgboost fixes the hangs in the other tests.

@galipremsagar galipremsagar mentioned this pull request Jun 22, 2022
Closed
galipremsagar
galipremsagar commented Jun 22, 2022
View reviewed changes
Comment thread ci/cpu/build.sh Outdated
galipremsagar
galipremsagar commented Jun 22, 2022
View reviewed changes
Comment thread ci/gpu/build.sh Outdated
@cjnolet

cjnolet commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

@gpucibot merge

@codecov-commenter

codecov-commenter commented Jun 23, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@ac1965a). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #4777   +/-   ##
===============================================
  Coverage                ?   77.62%           
===============================================
  Files                   ?      180           
  Lines                   ?    11382           
  Branches                ?        0           
===============================================
  Hits                    ?     8835           
  Misses                  ?     2547           
  Partials                ?        0
Flag Coverage Δ
dask 45.51% <0.00%> (?)
non-dask 67.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac1965a...7fa7e51. Read the comment docs.

@rapids-bot
rapids-bot Bot merged commit d1c61b2 into NVIDIA:branch-22.08 Jun 23, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@galipremsagar
Bump xgboost to 1.6.0 from 1.5.2 (NVIDIA#4777)
2e83cc4 
Rapids recently bumped the `xgbooot` to `1.6.0` from `1.5.2` in: rapidsai/integration#487, this PR adapts to those recent changes.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: NVIDIA#4777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dantegd dantegd dantegd approved these changes
@cjnolet cjnolet cjnolet approved these changes
@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

No one assigned

Labels

breaking Breaking change bug Something isn't working Cython / Python Cython or Python issue gpuCI gpuCI issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@galipremsagar @trivialfis @cjnolet @codecov-commenter @dantegd @ajschmidt8