Use clang-tools on x86 only - #3969
Merged
Merged
Conversation
jjacobelli
approved these changes
Jun 9, 2021
Contributor
Author
cjnolet
added
improvement
cjnolet
approved these changes
Jun 9, 2021
cjnolet
left a comment
cjnolet
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, pending style fix (looks like copyright).
jakirkham
marked this pull request as ready for review
June 9, 2021 18:48
jjacobelli
approved these changes
Jun 10, 2021
Collaborator
|
@gpucibot merge |
Contributor
Author
|
rerun tests |
3 similar comments
Contributor
Author
|
rerun tests |
Contributor
Author
|
rerun tests |
Contributor
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #3969 +/- ##
===============================================
Coverage ? 85.24%
===============================================
Files ? 230
Lines ? 18211
Branches ? 0
===============================================
Hits ? 15524
Misses ? 2687
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Member
|
I manually overrode the failing status check in order to merge this PR since the only failure was on the |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Since there is a specific version of `clang-tools` we need and it may be difficult to migrate that to other architectures, restrict installing `clang-tools` to x86. After all this is only needed for checking code style, which can be done just on x86 without loss of generality. Authors: - https://github.com/jakirkham Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#3969
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there is a specific version of
clang-toolswe need and it may be difficult to migrate that to other architectures, restrict installingclang-toolsto x86. After all this is only needed for checking code style, which can be done just on x86 without loss of generality.