Upgrade NCCL to 2.9.9 - #3902
Conversation
dantegd
added
improvement
|
Looks like the CI failures here are related to recent Dask changes, which were recently fixed here? Going to rerun tests to see. |
|
rerun tests |
1 similar comment
|
rerun tests |
|
rerun tests |
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Swapping which one is dev installed
dantegd
changed the title
Co-authored-by: jakirkham <jakirkham@gmail.com>
dantegd
changed the title
Co-authored-by: jakirkham <jakirkham@gmail.com>
| gpuci_logger "Install the main version of dask and distributed" | ||
| set -x | ||
| pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps | ||
| pip install "git+https://github.com/jakirkham/distributed.git@drop_whowhat_client" --upgrade --no-deps |
There was a problem hiding this comment.
This can be reverted once ready as it is merged
| pip install "git+https://github.com/jakirkham/distributed.git@drop_whowhat_client" --upgrade --no-deps | |
| pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps |
|
Note: PR is waiting for an equivalent in integration |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3902 +/- ##
===============================================
Coverage ? 85.07%
===============================================
Files ? 228
Lines ? 17775
Branches ? 0
===============================================
Hits ? 15122
Misses ? 2653
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
This change has been approved, is it good to go for the release? |
|
It's just waiting on rapidsai/integration#287 so that CI doesn't get issues after the merge |
|
@gpucibot merge |
Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) URL: NVIDIA#3902
5 participants
No description provided.