[WIP] Reduce redundant compilation through explicit specialization of extern templates [skip-ci] - #3514
Closed
wphicks wants to merge 8 commits into
Closed
[WIP] Reduce redundant compilation through explicit specialization of extern templates [skip-ci]#3514wphicks wants to merge 8 commits into
wphicks wants to merge 8 commits into
Conversation
wphicks
added
feature request
dantegd
reviewed
Feb 23, 2021
|
|
||
| # single GPU components | ||
| add_library(${CUML_CPP_TARGET} SHARED | ||
| src/specializations/prims/selection/knn.cu |
Contributor
There was a problem hiding this comment.
I love the execution of how you have proposed and organized this!
The only things I can think off the top of my head are:
- Add somewhere a readme that lists what functions have been specialized (maybe a markdown in the C++) to make it very easy and obvious how to use/reference/add specializations, unless you think this would be redundant. I think it could be valuable if we get a significantly large number of specializations.
- Add a section to the C++ developer guide with usage guides and also guidelines of when a new specialization is preferred over importing the prims/raft functions directly.
What do you think?
Contributor
Author
There was a problem hiding this comment.
I think both of those are great ideas! I've written scripts to help automate generation of the specializations, so I'll add something to them to start generating the markdown list as well.
|
This PR has been labeled |
Contributor
|
Will re-post after other header cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET: Posting this to facilitate discussion
Declare some of the most redundantly-compiled templates as extern and provide explicit specializations in order to reduce unnecessary compilation time