FIX Update cupy to >= 7.8 and remove unused build.sh script - #3378
Merged
Conversation
ajschmidt8
requested changes
Jan 15, 2021
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
We'll need to update this in the integration repo below.
Also, looks like the spec will need to be adjusted in the other repos:
- https://github.com/rapidsai/cuxfilter/blob/branch-0.18/conda/recipes/cuxfilter/meta.yaml#L33
- https://github.com/rapidsai/cusignal/blob/branch-0.18/conda/recipes/cusignal/meta.yaml#L31
- https://github.com/rapidsai/cudf/blob/branch-0.18/conda/recipes/cudf/meta.yaml#L38
This was referenced Jan 19, 2021
JohnZed
approved these changes
Jan 19, 2021
Contributor
Author
|
rerun tests |
1 similar comment
Contributor
|
rerun tests |
dillon-cullinan
approved these changes
Jan 29, 2021
ajschmidt8
approved these changes
Jan 29, 2021
Contributor
|
@gpucibot merge |
Contributor
Author
|
rerun tests |
Contributor
|
rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3366
Also removes an older build.sh script that to my knowledge we don't use anymore
cc @beckernick who pointed out we need to bump it due to using cupy.full order parameter