[REVIEW] Bumping xgboost version to match cuml version - #3062
Merged
JohnZed merged 4 commits intoOct 28, 2020
Conversation
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
JohnZed
approved these changes
Oct 27, 2020
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3062 +/- ##
===============================================
+ Coverage 58.39% 59.23% +0.84%
===============================================
Files 143 142 -1
Lines 8897 8966 +69
===============================================
+ Hits 5195 5311 +116
+ Misses 3702 3655 -47
Continue to review full report at Codecov.
|
Contributor
|
I'm seeing Rerunning now to see if something transient is going on, otherwise will file as an issue. |
Contributor
|
rerun tests |
ajschmidt8
approved these changes
Oct 27, 2020
JohnZed
approved these changes
Oct 28, 2020
Contributor
|
Exception wrapper looks good! |
Contributor
|
rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading the xgboost version used in the build script to match the cuML version (since its a custom build of xgboost).
This follows a similar PR for integration: rapidsai/integration#166
However, unlike the integration change, we will match the xgboost version to the cuml version to avoid hitting this issue in the future.