[REVIEW] Upgrade Treelite to 0.93 - #2972
Merged
Merged
Conversation
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
dantegd
approved these changes
Oct 13, 2020
JohnZed
reviewed
Oct 13, 2020
| - umap-learn | ||
| - scikit-learn=0.23.1 | ||
| - treelite=0.92 | ||
| - treelite=0.93 |
Contributor
There was a problem hiding this comment.
Maybe treelite >=0.92,<=0.93?
When we don't have a preference, it seems beneficial to be a little more flexible.
Contributor
Author
There was a problem hiding this comment.
We actually want to avoid 0.92 and use 0.93 exclusively, to avoid conflict with BlazingSQL.
Contributor
There was a problem hiding this comment.
0.93 is understood by conda as 0.93.* so we should be good to use this and pick up any patch/hotfixes
Contributor
Author
|
rerun tests |
1 similar comment
Contributor
|
rerun tests |
mike-wendt
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Treelite to 0.93 to use Protobuf 3.13. The version 0.93 is a very minor revision of 0.92. @JohnZed @kkraus14
Depends on rapidsai/integration#151