Skip to content

remove-render-only-tests - #688

Merged
yanqinz2 merged 1 commit into
NVIDIA:developfrom
yanqinz2:fix-663
Aug 21, 2026
Merged

remove-render-only-tests#688
yanqinz2 merged 1 commit into
NVIDIA:developfrom
yanqinz2:fix-663

Conversation

@yanqinz2

@yanqinz2 yanqinz2 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Before submitting

  • I agree to license this contribution under the terms of LICENSE.txt.
  • I ran pre-commit run and committed any formatting changes.
  • I added GitHub labels: one cat-*, one or more mod-*, and one orig-* (see label list).

Affected area

Summary

Remove render only test since we don't have AOT compilation logic

Why

Related issues

API and compatibility impact

Testing

Summary by CodeRabbit

  • Tests
    • Expanded block-scale matrix multiplication execution coverage across SM103–SM109 architectures.
    • Removed renderer and compile-smoke coverage for selected pipelines.
    • Removed validation for generated-kernel constants, tile constants, TMEM columns, and unsupported formats.
    • Retained runtime, analyzer, registry, and numerical test coverage.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a1f7a9b5-fc32-4f23-bca4-d1d33acce2a0

📥 Commits

Reviewing files that changed from the base of the PR and between 4bcb45e and 0ecbcd8.

📒 Files selected for processing (1)
  • test/python/gemm/frost/test_block_scale_matmul.py

📝 Walkthrough

Walkthrough

Changes

The pull request broadens requires_sm103 execution coverage from SM103 to SM103–SM109. It removes selected renderer, compile-smoke, and tile-constant tests from the block-scale matmul suite. Runtime, analyzer, registry, and numerical tests remain.

Block-scale matmul test coverage

Layer / File(s) Summary
Broaden architecture test coverage
test/python/gemm/frost/test_block_scale_matmul.py
Allows requires_sm103 tests to run on SM103 through SM109.
Remove sm103 renderer coverage
test/python/gemm/frost/test_block_scale_matmul.py
Removes sm103 renderer helpers and tests for generated-kernel compilation, constants, interleaving, mxfp8 rejection, and compile-smoke configurations.
Remove sm107 renderer coverage
test/python/gemm/frost/test_block_scale_matmul.py
Removes sm107 renderer constant validation and TMEM allocation tests.
Remove E5M3 tile validation
test/python/gemm/frost/test_block_scale_matmul.py
Removes E5M3 renderer tile-constant validation for block sizes 16 and 32.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: yangxu1990uiuc

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the summary but omits the affected area, rationale, compatibility impact, and testing details. Complete the affected area, Why, API and compatibility impact, and Testing sections with the relevant selections, impacts, commands, and results.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the removal of render-only tests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yanqinz2 yanqinz2 added the cat-bug Reports of incorrect behavior, crashes, regressions, or unexpected results. label Aug 20, 2026
@yanqinz2
yanqinz2 merged commit ff3601c into NVIDIA:develop Aug 21, 2026
1 check was pending
@yanqinz2
yanqinz2 deleted the fix-663 branch August 21, 2026 00:04
@Anerudhan Anerudhan mentioned this pull request Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat-bug Reports of incorrect behavior, crashes, regressions, or unexpected results.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants