test(dsa): compare only the effective top-k slice - #672
Merged
hwanseoc merged 1 commit intoAug 20, 2026
Conversation
When top_k exceeds a row's sequence length, the reference pads the rest of the row with zeros while the kernel leaves the slots at their sentinel init, so comparing whole rows compared two different paddings and failed with inf differences. Cap both sides at min(top_k, seq_len), which is what the surrounding comment already described.
hwanseoc
added
cat-ci
Member
Author
|
@cudnn-ci-bot run oss |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-672-9a78675 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSS CI fix.
check_ref_indexer_top_kcompared whole output rows. Whentop_kexceeds a row's sequence length, onlymin(top_k, seq_len)entries are actually picked — past that the reference pads with zeros while the kernel leaves its sentinel init, so the comparison was between two different paddings:Caps both sides at the effective
k, which is what the surrounding comment already described but the code did not do.@coderabbitai ignore