Skip to content

benchmark(sdpa): qwen3vl_vit writes to results/ like every other config - #629

Merged
brandonfzhang merged 1 commit into
NVIDIA:developfrom
brandonfzhang:qwen3vl-vit-output-dir
Aug 17, 2026
Merged

benchmark(sdpa): qwen3vl_vit writes to results/ like every other config#629
brandonfzhang merged 1 commit into
NVIDIA:developfrom
brandonfzhang:qwen3vl-vit-output-dir

Conversation

@brandonfzhang

@brandonfzhang brandonfzhang commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

The qwen3vl_vit config omitted output_dir, falling to BenchmarkConfig's default of "../results" — one directory above where every other config (output_dir="results") writes, and where tooling that collects runner output looks. One line: set output_dir="results" to match the rest of the configs.

Summary by CodeRabbit

  • New Features
    • Added a default results output directory for the Qwen3VL vision benchmark configuration.

The qwen3vl_vit config omitted output_dir, falling to BenchmarkConfig's
default of '../results' — one directory above where every other config
(output_dir='results') writes and where tooling collecting runner output
looks. Set output_dir='results' to match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 429ca939-c61d-4758-b4bd-2a926913690b

📥 Commits

Reviewing files that changed from the base of the PR and between 6c39f8b and bed07d3.

📒 Files selected for processing (1)
  • benchmark/sdpa_benchmark_training/configs/qwen3vl_vit.py

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The Qwen3-VL ViT benchmark configuration now sets output_dir to results.

Changes

Benchmark output configuration

Layer / File(s) Summary
Configure benchmark output directory
benchmark/sdpa_benchmark_training/configs/qwen3vl_vit.py
The configuration sets output_dir="results".

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bed07

This localized configuration change makes qwen3vl_vit write benchmark results to the standard results directory used by the other configurations; no actionable merge-blocking risk remains.

Suggested reviewers: vedaanta

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and reason but omits the required checklist, affected area, related issues, compatibility impact, and testing sections. Add the required template sections and provide checklist status, affected area, related issues, compatibility impact, and exact testing results.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the benchmark configuration and its output-directory alignment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brandonfzhang
brandonfzhang merged commit ab16bc8 into NVIDIA:develop Aug 17, 2026
1 check passed
hxbai pushed a commit to hxbai/cudnn-frontend that referenced this pull request Aug 18, 2026
…ig (NVIDIA#629)

The qwen3vl_vit config omitted output_dir, falling to BenchmarkConfig's
default of '../results' — one directory above where every other config
(output_dir='results') writes and where tooling collecting runner output
looks. Set output_dir='results' to match.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@Anerudhan Anerudhan mentioned this pull request Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants