benchmark(sdpa): qwen3vl_vit writes to results/ like every other config - #629
Conversation
The qwen3vl_vit config omitted output_dir, falling to BenchmarkConfig's default of '../results' — one directory above where every other config (output_dir='results') writes and where tooling collecting runner output looks. Set output_dir='results' to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe Qwen3-VL ViT benchmark configuration now sets ChangesBenchmark output configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized configuration change makes qwen3vl_vit write benchmark results to the standard results directory used by the other configurations; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ig (NVIDIA#629) The qwen3vl_vit config omitted output_dir, falling to BenchmarkConfig's default of '../results' — one directory above where every other config (output_dir='results') writes and where tooling collecting runner output looks. Set output_dir='results' to match. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The qwen3vl_vit config omitted
output_dir, falling toBenchmarkConfig's default of"../results"— one directory above where every other config (output_dir="results") writes, and where tooling that collects runner output looks. One line: setoutput_dir="results"to match the rest of the configs.Summary by CodeRabbit
resultsoutput directory for the Qwen3VL vision benchmark configuration.