fix missing attribute in Rubin grouped dGLU - #625
Conversation
Signed-off-by: Hristo Filaretov <hfilaretov@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe constructor now stores ChangesRuntime offset configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change assigns the missing runtime attribute in the Rubin grouped dGLU path, preventing the reported attribute error. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
I can't seem to add labels, but these are relevant: |
|
@cudnn-ci-bot run oss |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-625-09b93c6 |
Signed-off-by: Hristo Filaretov <hfilaretov@nvidia.com>
Before submitting
pre-commit runand committed any formatting changes.cat-*, one or moremod-*, and oneorig-*(see label list).Affected area
Summary
A variable wasn't assigned to an attribute, so we hit a missing attribute later in the code.
Traceback snippet:
Related PRs
Related to #588 and #590.
Testing
I ran our failing training runs with this patch and they worked.
Summary by CodeRabbit