Skip to content

fix: remove guardwords-breaking dGLU comment - #441

Merged
Anerudhan merged 1 commit into
NVIDIA:developfrom
saltyminty:fix/mingyangw/manual
Jul 27, 2026
Merged

fix: remove guardwords-breaking dGLU comment#441
Anerudhan merged 1 commit into
NVIDIA:developfrom
saltyminty:fix/mingyangw/manual

Conversation

@saltyminty

@saltyminty saltyminty commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Before submitting

  • I agree to license this contribution under the terms of LICENSE.txt.
  • I ran pre-commit run and committed any formatting changes.

Affected area

FE OSS kernels or CuTeDSL

Summary

Remove an unprofessional comment from the BF16 grouped GEMM dGLU kernel.

Why

The comment triggers the guardwords COMMENT:broken CI check and does not add
useful maintainer context. Removing it resolves the reported failure without
changing executable code.

Related issues

None.

API and compatibility impact

None. The change removes one comment and leaves executable Python tokens
unchanged.

Testing

  • pre-commit run --files python/cudnn/grouped_gemm/grouped_gemm_dglu/moe_grouped_gemm_dglu_dbias.py
    • black: passed
    • black-jupyter: passed
    • clang-format: skipped because no applicable files changed
  • Audited comments in all 19 Python files added by PR feat: add BF16 grouped GEMM MoE kernels #415 using Python's
    standard-library tokenizer: 908 post-change comment tokens, zero prohibited
    candidates, and unchanged executable token streams.
  • git diff --check: passed.
  • GPU/runtime tests were not run because the change is comment-only.
  • The guardwords checker is not available in the repository checkout; its
    authoritative result is expected from CI.

Summary by CodeRabbit

  • Refactor
    • Removed an outdated internal code comment; no user-facing behavior or functionality changed.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fb2c6565-4813-4076-b71f-b025a9e79abd

📥 Commits

Reviewing files that changed from the base of the PR and between 3bf02bf and 68ed0cc.

📒 Files selected for processing (1)
  • python/cudnn/grouped_gemm/grouped_gemm_dglu/moe_grouped_gemm_dglu_dbias.py
💤 Files with no reviewable changes (1)
  • python/cudnn/grouped_gemm/grouped_gemm_dglu/moe_grouped_gemm_dglu_dbias.py

📝 Walkthrough

Walkthrough

The change removes one inline comment before the tensor-memory load operation in the epilogue subtile loop. No executable logic or public declarations are modified.

Changes

Grouped GEMM cleanup

Layer / File(s) Summary
Epilogue comment cleanup
python/cudnn/grouped_gemm/grouped_gemm_dglu/moe_grouped_gemm_dglu_dbias.py
Removes the inline AST/constexpr tracking comment before copy_atom_t2r; the tensor-memory load logic remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing a guardwords-breaking dGLU comment.
Description check ✅ Passed The description matches the template and includes the required sections, with clear summary, rationale, impact, and testing details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Anerudhan Anerudhan added mod-frontend cuDNN frontend APIs, operation graph construction, plans, and user-facing wrappers. orig-nv-eng Reported or requested by NVIDIA engineering. cat-enhancements labels Jul 27, 2026
@Anerudhan Anerudhan added this to the Frontend 1.27.0 milestone Jul 27, 2026
@Anerudhan
Anerudhan merged commit 1d6f6d9 into NVIDIA:develop Jul 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat-enhancements mod-frontend cuDNN frontend APIs, operation graph construction, plans, and user-facing wrappers. orig-nv-eng Reported or requested by NVIDIA engineering.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants