Preserve the CUDA default stream in DSA wrappers - #355
Closed
kunlunl wants to merge 1 commit into
Closed
Conversation
Signed-off-by: kunlunl <kunlunl@nvidia.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
Superseded by #354, which now contains this fix as a separate signed-off commit and passed the combined H100 DSA validation (3 targeted regressions and 24/24 DSA tests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use
torch.cuda.get_stream_from_external()when entering a caller-supplied CUDA stream.Why
torch.cuda.ExternalStream(0)does not preserve the legacy default-stream handle. It produces a different pooled stream, so PyTorch setup or copy operations performed inside the wrapper can race a CuTe kernel launched on stream 0.get_stream_from_external()preserves both the zero default-stream handle and nonzero external stream handles.Validation
Run on an H100 (SM90) with PyTorch 2.12, CUDA 13.2, and cuDNN Frontend built from current
develop:develop: failed as expected because the active handle was nonzero.test/python/fe_api/dsasuite: 22 passed.