Skip to content

[REVIEW] Pin max dask & distributed versions - #9734

Merged
ajschmidt8 merged 4 commits into
NVIDIA:branch-21.12from
galipremsagar:dask_pin_new
Nov 22, 2021
Merged

[REVIEW] Pin max dask & distributed versions#9734
ajschmidt8 merged 4 commits into
NVIDIA:branch-21.12from
galipremsagar:dask_pin_new

Conversation

@galipremsagar

@galipremsagar galipremsagar commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

This PR introduces max version pinnings for dask & distributed to 2021.11.2

@galipremsagar galipremsagar self-assigned this Nov 19, 2021
@galipremsagar
galipremsagar requested review from a team as code owners November 19, 2021 16:23
@galipremsagar
galipremsagar requested review from cwharris, jakirkham, quasiben and skirui-source and removed request for a team November 19, 2021 16:23
@github-actions github-actions Bot added conda Python Affects Python cuDF API. labels Nov 19, 2021
This was referenced Nov 19, 2021
Merged
Merged
Merged
Merged
Merged
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Nov 19, 2021
bdice
bdice requested changes Nov 19, 2021
View reviewed changes
Comment thread conda/recipes/dask-cudf/meta.yaml Outdated
@galipremsagar @bdice
Update conda/recipes/dask-cudf/meta.yaml
b1cafad 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
galipremsagar
galipremsagar commented Nov 19, 2021
View reviewed changes
Comment thread conda/recipes/dask-cudf/meta.yaml Outdated
- cudf {{ version }}
- dask>=2021.09.1
- dask>=2021.09.1,<=2021.11.2
- distributed>=2021.09.1

@galipremsagar galipremsagar Nov 19, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- distributed>=2021.09.1
- distributed>=2021.09.1,<=2021.11.2

jakirkham
jakirkham reviewed Nov 19, 2021
View reviewed changes

@jakirkham jakirkham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion offline suggesting we constrain dask & distributed with >=2021.11.1,<=2021.11.2

Comment thread conda/environments/cudf_dev_cuda11.0.yml Outdated
Comment thread conda/environments/cudf_dev_cuda11.2.yml Outdated
Comment thread conda/environments/cudf_dev_cuda11.5.yml Outdated
Comment thread conda/recipes/custreamz/meta.yaml Outdated
Comment thread conda/recipes/dask-cudf/meta.yaml Outdated
Comment thread conda/recipes/dask-cudf/meta.yaml Outdated
Comment thread python/custreamz/dev_requirements.txt Outdated
Comment thread python/dask_cudf/dev_requirements.txt Outdated
Comment thread python/dask_cudf/setup.py Outdated
@galipremsagar @jakirkham
Apply suggestions from code review
e69cdd8 
Co-authored-by: jakirkham <jakirkham@gmail.com>
@codecov

codecov Bot commented Nov 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #9734 (2633873) into branch-21.12 (cb894e0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2633873 differs from pull request most recent head e69cdd8. Consider uploading reports for the commit e69cdd8 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.12    #9734   +/-   ##
=============================================
  Coverage         10.61%   10.61%           
=============================================
  Files               118      118           
  Lines             20075    20072    -3     
=============================================
  Hits               2130     2130           
+ Misses            17945    17942    -3
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb894e0...e69cdd8. Read the comment docs.

rapids-bot Bot pushed a commit to NVIDIA/cuml that referenced this pull request Nov 21, 2021
@galipremsagar
Pin max dask and distributed to 2012.11.2 (#4390)
edb77e9 
Changes to be in-line with: NVIDIA/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #4390
pentschev
pentschev approved these changes Nov 22, 2021
View reviewed changes

@pentschev pentschev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

rapids-bot Bot pushed a commit to rapidsai/cugraph that referenced this pull request Nov 22, 2021
@galipremsagar
Pin max dask & distributed to 2021.11.2 (#1958)
5f5ccc3 
Changes to be in-line with: NVIDIA/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: #1958
rapids-bot Bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Nov 22, 2021
@galipremsagar
Pin max dask & distributed versions (#794)
a9d2554 
Changes to be in-line with NVIDIA/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #794
@ajschmidt8
ajschmidt8 merged commit 8e2ac44 into NVIDIA:branch-21.12 Nov 22, 2021
rapids-bot Bot pushed a commit to NVIDIA/raft that referenced this pull request Nov 22, 2021
@galipremsagar
Pin max dask & distributed (#388)
8ef8166 
Changes to be in-line with: NVIDIA/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #388
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Pin max dask and distributed to 2012.11.2 (NVIDIA#4390)
a54a5d4 
Changes to be in-line with: NVIDIA/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: NVIDIA#4390
loulankxh pushed a commit to loulankxh/raft that referenced this pull request Oct 14, 2025
@galipremsagar
Pin max dask & distributed (NVIDIA#388)
108137a 
Changes to be in-line with: NVIDIA/cudf#9734

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: NVIDIA#388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham left review comments
@bdice bdice bdice approved these changes
@pentschev pentschev pentschev approved these changes
@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes
@cwharris cwharris Awaiting requested review from cwharris cwharris was automatically assigned from rapidsai/cudf-python-codeowners
@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source was automatically assigned from rapidsai/cudf-python-codeowners
@quasiben quasiben Awaiting requested review from quasiben

Assignees

@galipremsagar galipremsagar

Labels

bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@galipremsagar @jakirkham @bdice @pentschev @ajschmidt8