Skip to content

Remove flatbuffers dependency - #8671

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-21.08from
jjacobelli:remove-flatbuffers
Jul 7, 2021
Merged

Remove flatbuffers dependency#8671
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-21.08from
jjacobelli:remove-flatbuffers

Conversation

@jjacobelli

Copy link
Copy Markdown
Contributor

As discussed with @jakirkham and @trxcllnt, cudf does not depend directly on flatbuffers so we can remove the dependency

Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli
jjacobelli requested review from a team as code owners July 7, 2021 14:44
@github-actions github-actions Bot added conda Python Affects Python cuDF API. labels Jul 7, 2021
@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 7, 2021
@jjacobelli jjacobelli self-assigned this Jul 7, 2021
@jjacobelli

Copy link
Copy Markdown
Contributor Author

Integration PR: rapidsai/integration#309

@jakirkham
jakirkham requested a review from trxcllnt July 7, 2021 16:32
@codecov

codecov Bot commented Jul 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #8671 (edeab2f) into branch-21.08 (7721819) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head edeab2f differs from pull request most recent head d338119. Consider uploading reports for the commit d338119 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8671      +/-   ##
================================================
+ Coverage         10.62%   10.64%   +0.01%     
================================================
  Files               109      109              
  Lines             18289    18654     +365     
================================================
+ Hits               1943     1985      +42     
- Misses            16346    16669     +323     
Impacted Files Coverage Δ
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7721819...d338119. Read the comment docs.

@jjacobelli

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 718eccf into NVIDIA:branch-21.08 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants