[REVIEW] Upgrade pandas to 1.2 - #7375
Conversation
|
rerun tests |
|
@gpucibot merge |
| - fsspec>=0.6.0 | ||
| - {{ pin_compatible('cudatoolkit', max_pin='x.x') }} | ||
| - nvtx >=0.2.1 | ||
| - packaging |
There was a problem hiding this comment.
Does this need to be added to the integration repo as well?
There was a problem hiding this comment.
Would defer to @ajschmidt8 here, there was a build job-related failure at this line https://github.com/rapidsai/cudf/blob/branch-0.19/ci/cpu/build.sh#L78-L79 so AJ suggested we add it here.
There was a problem hiding this comment.
Feel free to review. I will wait to merge until this PR is confirmed passing also.
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7375 +/- ##
===============================================
+ Coverage 81.80% 82.33% +0.52%
===============================================
Files 101 101
Lines 16695 17198 +503
===============================================
+ Hits 13658 14160 +502
- Misses 3037 3038 +1
Continue to review full report at Codecov.
|
Fixes: #7367, #7446
This PR upgrades pandas to
1.2.2incudf. Changes include:pandasversion.isinbehavior which now takes in types into accout: DOC: Undocumented change in .isin behavior from 1.1.5 to 1.2.0 pandas-dev/pandas#38781CategoricalColumn.__setitem__will now not allow setting of values that are not in existing categories.cudf.core._compat.PANDAS_GE_120variable to create back-ward compatibility.pd.core.tools.datetimes._guess_datetime_formattopd.core.tools.datetimes.guess_datetime_formatstd&medianinDateTimeColumn.StringMethodsas an input to methods in string APIs.is_validofScalar.TimeDeltaColumn.sumlogic for empty inputs.dtype='float64'wherever there is an empty series being created since pandas will soon be defaulting toobjectdtype if no type is passed and we don't have a perfectly resemblingobjectdtype as that of pandas.Index.__or__andIndex.__xor__by replacing withunion&symmetric_differenceAPIs.float32&float64dtypes to pandas Nullable dtypesFLoat32Dtype&Float64Dtypewhennullable=Trueinto_pandas.MultiIndexfrom dataframe: BUG: Unable to create a MultiIndex withnanvalues in nullableFloatdtypes pandas-dev/pandas#39984, so introduced a workaround in ourMultiIndex.__repr__code.check_less_precisein our code-base as this is deprecated and is replaced withrtol&atol. Retained its usages in our testing APIs for back-ward compatibility.xfailcases which are actually passing right now because of resolved issues in bothpandas&cudf.from pandas import Seriesand some dofrom cudf.core import Series. So removed both patterns and doing only simpleimport cudf&import pandas as pdto avoid confusion while debugging test failures across multiple files. (Made this change in all pytest files which I had to touch as part of pandas upgrade, we can make similar changes in future for the files which we touch).np.nanvalues to aCategoricalColumnand fix related__repr__code: [BUG] Unable to assignnull/nanin categorical column #7446