Fix skiprows issue with ORC Reader - #7359
Merged
rapids-bot[bot] merged 5 commits intoFeb 15, 2021
Merged
Conversation
ramakrishnap-nv
added
bug
ramakrishnap-nv
requested review from
devavret,
galipremsagar,
isVoid,
karthikeyann and
vuule
February 9, 2021 22:43
galipremsagar
requested changes
Feb 9, 2021
galipremsagar
approved these changes
Feb 9, 2021
galipremsagar
left a comment
galipremsagar
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @rgsl888prabhu for the fix!
vuule
reviewed
Feb 10, 2021
vuule
reviewed
Feb 10, 2021
vuule
approved these changes
Feb 11, 2021
vuule
reviewed
Feb 11, 2021
| import pandas as pd | ||
| import pyarrow as pa | ||
| import pyarrow.orc | ||
| import pyorc |
Contributor
There was a problem hiding this comment.
CI fails because of this import
ModuleNotFoundError: No module named 'pyorc'
Contributor
Author
There was a problem hiding this comment.
Created a PR for it rapidsai/integration#215
vuule
approved these changes
Feb 11, 2021
vuule
left a comment
vuule
left a comment
Contributor
There was a problem hiding this comment.
approved once more, for good measure :)
Contributor
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7359 +/- ##
==============================================
Coverage ? 82.19%
==============================================
Files ? 100
Lines ? 16968
Branches ? 0
==============================================
Hits ? 13947
Misses ? 3021
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
|
@gpucibot merge |
vyasr
added
4 - Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7343
The validity bits in streams are placed msb to lsb in a byte, [True, False, True. False. True, True, True, False] -> 10101110.
So, when it is being analyzed as 32 bit chunk, we can't apply mask directly, which caused this issue.
__brev(__byte_perm(bits, 0, 0x0123))takes care of that issue and rearranges the bits as per the expectation.