[REVIEW] Add nvtext::porter_stemmer_measure API - #5767
Merged
davidwendt merged 25 commits intoAug 5, 2020
Merged
Conversation
Collaborator
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Contributor
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5767 +/- ##
===============================================
+ Coverage 84.08% 84.41% +0.33%
===============================================
Files 80 80
Lines 13062 13395 +333
===============================================
+ Hits 10983 11308 +325
- Misses 2079 2087 +8
Continue to review full report at Codecov.
|
davidwendt
marked this pull request as ready for review
July 27, 2020 23:08
Contributor
Author
|
rerun tests |
kkraus14
suggested changes
Jul 28, 2020
kkraus14
approved these changes
Jul 28, 2020
galipremsagar
approved these changes
Jul 29, 2020
Contributor
|
Don't merge this as one cpp review is still pending. |
codereport
suggested changes
Aug 4, 2020
codereport
left a comment
Contributor
There was a problem hiding this comment.
This code looks great! And it is such a cool algorithm. Only 1 small change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #5243
This PR adds nvtext APIs to unblock NVIDIA/cuml#2476
It includes two new APIs ported from the old NVText implementation as referenced in #5243
The algorithm is based on https://tartarus.org/martin/PorterStemmer/def.txt
The main difference is since this algorithm only works on English, the
aeiouandycharacters are hardcoded inside the implementation. The previous NVText version allowed these to be parameters.This PR will include adding the Python interface as well.